The following errata report has been submitted for RFC8033, "Proportional Integral Controller Enhanced (PIE): A Lightweight Control Scheme to Address the Bufferbloat Problem".
-------------------------------------- You may review the report below and at: http://www.rfc-editor.org/errata/eid5095 -------------------------------------- Type: Technical Reported by: Liang Tian <[email protected]> Section: 5.2 Original Text ------------- if PIE->in_measurement_ == TRUE: PIE->dq_count_ = PIE->dq_count_ + deque_pkt_size; if PIE->dq_count_ >= DQ_THRESHOLD then weight = DQ_THRESHOLD/2^16 PIE->avg_dq_time_ = (now - PIE->measurement_start_) * weight + PIE->avg_dq_time_ * (1 - weight); PIE->dq_count_ = 0; PIE->measurement_start_ = now else PIE->in_measurement_ = FALSE; Corrected Text -------------- if PIE->in_measurement_ == TRUE: PIE->dq_count_ = PIE->dq_count_ + deque_pkt_size; if PIE->dq_count_ >= DQ_THRESHOLD then weight = DQ_THRESHOLD/2^16 PIE->avg_dq_time_ = (now - PIE->measurement_start_) * weight + PIE->avg_dq_time_ * (1 - weight); PIE->in_measurement_ = FALSE; Notes ----- There should not be an "else" because if PIE->dq_count_ >= DQ_THRESHOLD, this measurement is over: avg_dq_time is calculated and in_measurement is set to FALSE; otherwise dq_count has been increased before this "if" and now we wait for next packet. Resetting dq_count and measurement_start is not necessary because they will be set again when a new measurement begins. Instructions: ------------- This erratum is currently posted as "Reported". If necessary, please use "Reply All" to discuss whether it should be verified or rejected. When a decision is reached, the verifying party can log in to change the status and edit the report, if necessary. -------------------------------------- RFC8033 (draft-ietf-aqm-pie-10) -------------------------------------- Title : Proportional Integral Controller Enhanced (PIE): A Lightweight Control Scheme to Address the Bufferbloat Problem Publication Date : February 2017 Author(s) : R. Pan, P. Natarajan, F. Baker, G. White Category : EXPERIMENTAL Source : Active Queue Management and Packet Scheduling Area : Transport Stream : IETF Verifying Party : IESG _______________________________________________ aqm mailing list [email protected] https://www.ietf.org/mailman/listinfo/aqm
