Jakub Klinkovský pushed to branch main at Arch Linux / Packaging / Packages / 
munge


Commits:
35da2d24 by David Runge at 2026-07-18T10:27:24+02:00
Rely on an alpm-hooks file to create the random munge key on installation

Use the more declarative and generic approach of an alpm-hook file to
create the random munge key upon installation.

Signed-off-by: David Runge <[email protected]>

- - - - -


4 changed files:

- .SRCINFO
- PKGBUILD
- + munge-create-key.hook
- − munge.install


Changes:

=====================================
.SRCINFO
=====================================
@@ -3,7 +3,6 @@ pkgbase = munge
        pkgver = 0.5.18
        pkgrel = 1
        url = https://github.com/dun/munge
-       install = munge.install
        arch = x86_64
        license = GPL-3.0-or-later
        license = LGPL-3.0-or-later
@@ -17,8 +16,10 @@ pkgbase = munge
        source = https://github.com/dun/munge/archive/munge-0.5.18.tar.gz
        source = munge.sysusers
        source = munge.tmpfiles
+       source = munge-create-key.hook
        sha512sums = 
39a59bc70b523ae7d449925c6864e86e9c6b8916003b6ab765c1c38eebc64d4ae4b8144b0d28b4d4cdac41586090eb21a9bcf497f519d317cd6a2fc834eabbfe
        sha512sums = 
f2c71ba6526ce550a601245809fec671d6dfcd12930ba533febcaf5c500b6b300333b6500056542196cf32cbe5c94fb358fcd9d53f74d3ffd825facbe78deebd
        sha512sums = 
33e3210634c1d5aa14597d70ec73c49aa83e9e0cea5c98a656099016876d2bf4dc8e1ec20426ee0baba9522be2e6a4422fa67a028ebf5e7c04f72f7daf0fd53f
+       sha512sums = 
69ac9b7e27f20241f004410df79ec9e057fb95e92cf87fb118602bddb8cc0e8cbb89fd2e62f18d976981a772ec5d9716c440e1be2dc2bceb36fe4d9f8bede1c1
 
 pkgname = munge


=====================================
PKGBUILD
=====================================
@@ -19,13 +19,14 @@ depends=(
 )
 makedepends=(systemd)
 checkdepends=(procps-ng)
-install="$pkgname.install"
 source=("https://github.com/dun/munge/archive/$pkgname-$pkgver.tar.gz";
         "munge.sysusers"
-        "munge.tmpfiles")
+        "munge.tmpfiles"
+        "munge-create-key.hook")
 
sha512sums=('39a59bc70b523ae7d449925c6864e86e9c6b8916003b6ab765c1c38eebc64d4ae4b8144b0d28b4d4cdac41586090eb21a9bcf497f519d317cd6a2fc834eabbfe'
             
'f2c71ba6526ce550a601245809fec671d6dfcd12930ba533febcaf5c500b6b300333b6500056542196cf32cbe5c94fb358fcd9d53f74d3ffd825facbe78deebd'
-            
'33e3210634c1d5aa14597d70ec73c49aa83e9e0cea5c98a656099016876d2bf4dc8e1ec20426ee0baba9522be2e6a4422fa67a028ebf5e7c04f72f7daf0fd53f')
+            
'33e3210634c1d5aa14597d70ec73c49aa83e9e0cea5c98a656099016876d2bf4dc8e1ec20426ee0baba9522be2e6a4422fa67a028ebf5e7c04f72f7daf0fd53f'
+            
'69ac9b7e27f20241f004410df79ec9e057fb95e92cf87fb118602bddb8cc0e8cbb89fd2e62f18d976981a772ec5d9716c440e1be2dc2bceb36fe4d9f8bede1c1')
 
 prepare() {
   cd $pkgname-$pkgname-$pkgver
@@ -58,6 +59,7 @@ package() {
 
   install -D -m644 ../munge.sysusers "$pkgdir"/usr/lib/sysusers.d/munge.conf
   install -D -m644 ../munge.tmpfiles "$pkgdir"/usr/lib/tmpfiles.d/munge.conf
+  install -vDm 644 ../munge-create-key.hook -t 
"$pkgdir"/usr/share/libalpm/hooks/
 
   # The dir /var/run/munge will be created by systemd-tmpfiles
   rm -rf "$pkgdir"/var/run/munge


=====================================
munge-create-key.hook
=====================================
@@ -0,0 +1,10 @@
+[Trigger]
+Type = Package
+Operation = Install
+Target = munge
+
+[Action]
+Description = Creating random munge key...
+Depends = coreutils
+Exec = /usr/bin/sh -c '[ ! -c /dev/urandom ] && printf "No /dev/urandom, 
skipping...\n" && exit; [ -f /etc/munge/munge.key ] && printf 
"/etc/munge/munge/munge.key exists, skipping...\n" && exit; dd if=/dev/urandom 
bs=1 count=1024 of=/etc/munge/munge.key; chown munge:munge 
/etc/munge/munge.key; chmod 0400 /etc/munge/munge.key'
+When = PostTransaction


=====================================
munge.install deleted
=====================================
@@ -1,13 +0,0 @@
-post_install() {
-       if [[ ! -e /etc/munge/munge.key && -c /dev/urandom ]]; then
-               echo "Creating random munge key at /etc/munge/munge.key"
-               dd if=/dev/urandom bs=1 count=1024 of=/etc/munge/munge.key
-               chmod 0400 /etc/munge/munge.key
-       else
-               if [[ -c /dev/urandom ]]; then
-                       echo "No munge key generated since /etc/munge/munge.key 
already exists."
-               else
-                       echo "Did not create /etc/munge/munge.key since 
/dev/urandom can not be found."
-               fi
-       fi
-}



View it on GitLab: 
https://gitlab.archlinux.org/archlinux/packaging/packages/munge/-/commit/35da2d24e048c83dfa56c1bac42d1de396b3bfc3

-- 
View it on GitLab: 
https://gitlab.archlinux.org/archlinux/packaging/packages/munge/-/commit/35da2d24e048c83dfa56c1bac42d1de396b3bfc3
You're receiving this email because of your account on gitlab.archlinux.org. 
Manage all notifications: https://gitlab.archlinux.org/-/profile/notifications 
| Help: https://gitlab.archlinux.org/help


Reply via email to