Allan McRae wrote:
Firmicus wrote:
Allan McRae a écrit :
Firmicus wrote:
... and a second one.
Cheers,
F
Hmmm.... finding it difficult to review this one.
OK, let me try to help.
On my system, with a virgin makepkg.conf in the chroot, the packages
made with makechrootpkg were copied to the file /pkgdest (where / is my
main root). So clearly trailing / were needed in lines 243, 246, 255 and
258.
Secondly. the tests such as
if [ -n "$PKGDEST" ]; then
in lines 241 and 253 were true, because $PKGDEST is by default the
string "/pkgdest". The directory /pkgdest however does not exist... so
there's a problem.
I see that there seems to be a confusion between the $PKGDEST on the
$uniondir and the one on the main system, right? Shouldn't the package
and sources be simply moved to $WORKDIR instead (as they used to iirc)?
Note that this patch applies to a commit
(486375ba0aedb185b369946fe565538c0f8e7949) that goes back to March, so I
am a bit surprised to be the first to have problems with it.
This is the actual cause of the issue:
http://bugs.archlinux.org/task/16006 . We used to copy the host
makepkg.conf in so the ${PKG,SRC}DEST variables were sourced from that
before being overwritten in the chroot. Removing the copying of the
system makepkg.conf screwed up the commit you mentioned.
BTW, I work around this on my system by reverting that commit. For
supporting building multiple arches, I have a makechrootpkg64 (my native
is i686) script that copies /etc/makepkg64.conf and adds a bunch of
linux64 calls in needed places.
Allan
