On Thu, Feb 11, 2010 at 5:49 PM, Thomas Bächler <[email protected]> wrote: > Am 11.02.2010 22:08, schrieb Ionut Biru: >> Hi, >> First the current implementation doesn't work since CONSOLEFONT is >> always zero. Second i don't know anything about fonts and why does the >> first commiter only enabled pfsu.gz fonts but i tested with a psf.gz >> font and is working fine and i decided to add any *.gz font. >> >> Comments? > > If you had posted your patch inline (as git intended it) I could comment > on it directly, but now thunderbird won't quote it. > > First, you introduced a broken if [ ... ] statement in the first hunk > that will cause an error (missing space). > > Second, the original commiter intended the console font to be set in > mkinitcpio.conf, so he can remove the consolefont setting in rc.conf. > Apparently his system boots faster this way. > > Third, using a * in finding the file may return several files. > Furthermore, the * won't be expanded because it is quoted. > > Did you test this patch at all?
Other than that, the concept is sound :)
