On Wed, Aug 10, 2011 at 07:44:39AM +1000, Allan McRae wrote: > On 10/08/11 07:36, Lukas Fleischer wrote: > >On Wed, Aug 10, 2011 at 07:17:52AM +1000, Allan McRae wrote: > >>On 10/08/11 06:53, Lukas Fleischer wrote: > >>>We already sourced the PKGBUILD, so no need to grep the name of the > >>>install script and changelog file. Just use "$install" and "$changelog" > >>>instead. > >> > >>Does this work with split packages each having their own install file? > > > >Crap. No, of course it doesn't. Still, I don't like the current way of > >grep'ing the PKGBUILD. While this will probably work in 99% of all > >cases, it doesn't cover all ways to set the "install" and "changelog" > >variables. My solution works fine for regular PKGBUILDs but doesn't work > >for split packages, yeah :/ > > > >If you want to keep the workaround, I'll discard this part of this patch > >and rebase the other ones. > > > > You could look at how it is done in makepkg in git currently as that > is slightly more robust. And of course, the PKGBUILD has to get > passed how makepkg parses it...
Well, as far as I can see, makepkg(8) currently uses exactly the same method that we currently use in commitpkg, so I'll revert that change, fix up and resubmit my patch set.
