On Sun, Sep 18, 2011 at 12:48 PM, Lukas Fleischer <[email protected]> wrote: > On Sat, Sep 17, 2011 at 04:43:33PM +0200, Jan Steffens wrote: >> >> Started rewriting: https://github.com/heftig/devtools/commits/master >> >> Comments welcome. > > There's a couple of more things that could be bashified (particularly > basename(1) and all the grep(1) and sed(1) invocations used in command > substitutions, since most of them can be replaced with bash parameter > expansion magic [1], [2], [3]). > > Apart from that, looks okay at a glance. > > [1] http://projects.archlinux.org/devtools.git/commit/?id=7952d6fb > [2] http://projects.archlinux.org/devtools.git/commit/?id=3c175e98 > [3] http://projects.archlinux.org/devtools.git/commit/?id=5688152f >
Updated the patchset. All uses of basename and some of the others have been removed.
