On Thu, Feb 07, 2013 at 10:14:57PM +0100, Jouke Witteveen wrote:
> On Thu, Feb 7, 2013 at 5:36 PM, Florian Pritz <[email protected]> wrote:
> > Signed-off-by: Florian Pritz <[email protected]>
> > ---
> >
> > Forgot to use the fqdn.
> >
> >  Makefile | 5 +++++
> >  1 file changed, 5 insertions(+)
> >
> > diff --git a/Makefile b/Makefile
> > index ad356e8..b5aca00 100644
> > --- a/Makefile
> > +++ b/Makefile
> > @@ -47,6 +47,11 @@ pkgbuild: PKGBUILD
> >  PKGBUILD: netctl-$(VERSION).tar.xz
> >         sed -e "s/%pkgver%/$(VERSION)/" -e "s/%md5sum%/$(shell md5sum $< | 
> > cut -d ' ' -f 1)/" contrib/PKGBUILD > $@
> >
> > +upload: netctl-$(VERSION).tar.xz
> > +       rm -f $<.sig
> > +       gpg --detach-sign $<
> 
> We should add *.sig to `make clean` and perhaps drop the rm above.
> 

I'd say that signing the tarball should be part of creating it.

> > +       scp $< $<.sig nymeria.archlinux.org:/srv/ftp/other/packages/netctl
> 
> Is that the right server? It used to be gerolde
> 

Yes. Used to be. We've got shiny new infrastructure.

> > +
> >  clean:
> >         $(MAKE) -C docs clean
> >         -@rm -vf PKGBUILD *.xz 2>/dev/null
> > --
> > 1.8.1.1

Reply via email to