On Sat, May 10, 2014 at 10:22:02PM -0400, Luke Shumaker wrote: > Hi, I maintain Parabola's "fork" of devtools. I've always had a set > of "generic" changes to contribute back upstream, but until now never > got around to pulling them into nice changesets. > > I also had one to allow makechrootpkg to handle arguments with spaces, > but I just sent that as a reply in another thread since Dave Reisner > seems to have just written the same thing! > > These are arranged roughly by how "controversial" I expect them to > be; I expect that no one will object to the first couple commits, > while someone might question the utility of the changes to > lock/slock. > > Happy hacking, > ~ Luke Shumaker
Modulo the comments I've made in 2 of the patches, this whole set gets an ACK from me. Thanks for contributing back upstream! > > Luke Shumaker (9): > arch-nspawn: Fix a grammar mistake (a/an) in an error message. > archbuild: Fix a variable name mistake. ($copydir -> $copy) > mkarchroot: Correct "Usage:" text. > makechrootpkg: Use the btrfs mountpoint/subvolume check consistently. > arch-nspawn: Avoid errors where $working_dir is longer than > HOST_NAME_MAX. > lib/common.sh: Add a lock_close function. > lib/common.sh:stat_busy(): Accept printf-style arguments. > lib/common.sh: Improve lock() and slock(). > Replace multiple uses of string interpolation with printf-type > arguments. > > arch-nspawn.in | 10 ++++++++-- > archbuild.in | 10 +++++----- > archrelease.in | 2 +- > checkpkg.in | 4 ++-- > crossrepomove.in | 8 ++++---- > lddd.in | 4 ++-- > lib/common.sh | 48 +++++++++++++++++++++++++++++++++++++----------- > makechrootpkg.in | 10 +++++----- > mkarchroot.in | 4 ++-- > rebuildpkgs.in | 14 +++++++------- > 10 files changed, 73 insertions(+), 41 deletions(-) > > -- > 1.9.2 >
