On Thu, 15 Feb 2018 15:09:57 -0500,
Eli Schwartz wrote:
>
> On 02/15/2018 02:04 PM, Luke Shumaker wrote:
> >> - [ -f "${FTP_BASE}/${PKGPOOL}/${pkgname}-${pkgver}-${pkgarch}"${PKGEXT}
> >> ] && return 1
> >> - [ -f
> >> "${FTP_BASE}/${PKGPOOL}/${pkgname}-${pkgver}-${pkgarch}"${PKGEXT}.sig ] &&
> >> return 1
> >> + [[ -f ${FTP_BASE}/${PKGPOOL}/${pkgname}-${pkgver}-${pkgarch}${PKGEXT}
> >> ]] && return 1
> >> + [[ -f
> >> ${FTP_BASE}/${PKGPOOL}/${pkgname}-${pkgver}-${pkgarch}${PKGEXT}.sig ]] &&
> >> return 1
> >
> > You don't want to do that here. In dbscripts, PKGEXT is a glob
> > pattern--it needs to be "unquoted"; and `[[ ... ]]`'s magic-quoting
> > breaks that. The closing-quote coming before ${PKGEXT} was quite
> > intentional.
>
> Seems like an easy thing to fix, we always use .pkg.tar.xz and using a
> glob there seems quite ugly.
> (What happens if it magically matches two files? The POSIX [ construct
> explodes and burns your house down.)
Disregard the bit about my version not being broken in my last
message---my spam filter had eaten this message. You are correct;
both versions are broken.
--
Happy hacking,
~ Luke Shumaker
