On 02/18/2018 12:17 PM, Luke Shumaker wrote: > From: Luke Shumaker <luke...@parabola.nu> > > This incorporates and improves on work from 3 previously submitted > patch sets: > > 1. My testcase patch, but > - take Eli's suggestion to simplify db-update.bats > - add another commit so we don't hit a bug in BATS > > 2. Renaming PKGEXT->PKGEXT_glob from my first fix patchset > > 3. Eli's fix/extglob patchset, but > - re-order things between commits > - also accept ".tar" (with no compression suffix) > - use `old_pkgs=()` instead of `unset old_pkgs` > - replace `[ -ge 1]` with `(( > 0 ))` instead of `(( > 1 ))` > - db-update: use `readarray < <(... | sort -u)` instead of the > O(n^2) op of using in_array in a for loop and appending to the > array > - common.bash, sourceballs.bats: update to work with shopt -s > extglob nullglob globstar; the tests needed updated too, not > just the main code > > The last 3 commits aren't really related to the goal of the patchset, > but I wanted to include all of the work from Eli's fix patchset. > > I don't mean to take credit away from Eli by re-working his patches (I > credit him in the commit messages); I just wanted to make it clearer > what is accomplished by each change, and how each of the changes > relate to our goals; as well as actually testing each of them against > the test suite. No need to resubmit someone else's amended patches, or resubmit not-amended patches with the statement "I've tested this" (you did that for devtools). Please just leave comments on the submitted patch.
I can resubmit the patch with a "v2: fix blahblahblah" comment after the commit message detailing what changed. I just won't have time until Monday. This also makes it easier to keep track of *which* patches are rerolls of previous patches. -- Eli Schwartz Bug Wrangler and Trusted User
Description: OpenPGP digital signature