On Mon, 26 Feb 2018 00:46:48 -0500,
Eli Schwartz wrote:
> > +++ b/db-functions
> > @@ -450,7 +450,7 @@ arch_repo_add() {
> > # package files might be relative to repo dir
> > pushd "${FTP_BASE}/${repo}/os/${arch}" >/dev/null
> > /usr/bin/repo-add -q "${repo}${DBEXT}" ${pkgs[@]} \
> > - || error "repo-add ${repo}${DBEXT} ${pkgs[@]}"
> > + || error 'repo-add %q %s' "${repo}${DBEXT}" "${pkgs[*]@Q}"
> > popd >/dev/null
> > set_repo_permission "${repo}" "${arch}"
> >
> > @@ -468,7 +468,7 @@ arch_repo_remove() {
> > return 1
> > fi
> > /usr/bin/repo-remove -q "${dbfile}" ${pkgs[@]} \
> > - || error "repo-remove ${dbfile} ${pkgs[@]}"
> > + || error 'repo-remove %q %s' "$dbfile" "${pkgs[*]@Q}"
> > set_repo_permission "${repo}" "${arch}"
>
> I think for consistency we should use the same style which means using
> "${dbfile@Q}"
I was going for consistency with the repo-add version, which doesn't
have a single dbfile variable to @Q. Would you have me introduce a
dbfile variable in arch_repo_add?
--
Happy hacking,
~ Luke Shumaker
