On Mon, 16 May 2011 23:52:17 -0300 Gerardo Exequiel Pozzi <[email protected]> wrote:
> On 05/16/2011 07:21 PM, Dan McGee wrote: > > On Mon, May 16, 2011 at 5:17 PM, Gerardo Exequiel Pozzi > > <[email protected]> wrote: > >> On 05/16/2011 07:08 PM, Dan McGee wrote: > >>> With that said, you've taken a totally job-agnostic script and > >>> hacked it to death for only [core], and it will do really silly > >>> things when maybe someone does want to download a full repo > >>> without exceptions. Why aren't you doing this in a more sane > >>> fashion outside of the script itself? I know this is going to be > >>> a bit of a hack wherever it ends up, but this is the wrong place > >>> to do it. > >>> > >>> dmcgee@galway ~/projects/archiso/configs/syslinux-iso (master) > >>> $ grep 'core' download-repo.sh | wc -l > >>> 0 > >>> > >> Yes, this is really bad. > >> > >> Maybe a newer script just for core-workaround ? > > I was thinking something a bit simpler. > > * Get the package names using `pacman -Slq $REPO` and drop the > > cut/tr B.S. at this level. Convert it to a bash array. > > * Command line takes an exclude list, or file, or something. Parse > > this into a bash array of package names, should be pretty > > straightforward. > > * Loop the pacman provided list of packages; if any value is present > > in the blacklist, drop it. > > * Proceed as we do now; when looping ^^ prepend "$REPO/" to each, > > and use this list for download. > > > > Obviously this isn't trivial, but it shouldn't be more than 20 lines > > or so. However, it makes it a lot easier to blacklist, unblacklist, > > and track said changes using version control once it is in place. > > > > -Dan > > > Yes, much better, I will see can I do... > +1 on that. properly implemented blacklisting will allow us to control us many more exceptions. not only as a workaround for these "they don't belong in core anyway" packages, but also for packages that do belong in core, but we strip out anyway to arrive at a size < 700MB. we'll just need to update some documentation here and there to mention the core images no longer include an exact copy of the core repository. Dieter
