On 05/27/16 03:44, Christian Hesse wrote: > Gerardo Exequiel Pozzi <[email protected]> on Thu, 2016/05/26 21:09: >> On 05/26/16 18:53, Christian Hesse wrote: >>> From: Christian Hesse <[email protected]> >>> >>> Booting from iPXE we can set bootif_mac without having BOOTIF around. >>> >>> Signed-off-by: Christian Hesse <[email protected]> >>> --- >>> archiso/initcpio/hooks/archiso_pxe_common | 5 ++++- >>> 1 file changed, 4 insertions(+), 1 deletion(-) >>> >>> diff --git a/archiso/initcpio/hooks/archiso_pxe_common >>> b/archiso/initcpio/hooks/archiso_pxe_common index 66eecfa..cedf585 100644 >>> --- a/archiso/initcpio/hooks/archiso_pxe_common >>> +++ b/archiso/initcpio/hooks/archiso_pxe_common >>> @@ -10,9 +10,12 @@ run_hook () { >>> # /tmp/net-*.conf >>> >>> if [[ -n "${ip}" ]]; then >>> - if [[ -n "${BOOTIF}" ]]; then >>> + if [[ -z "${bootif_mac}" && -n "${BOOTIF}" ]]; then >>> bootif_mac=${BOOTIF#01-} >>> bootif_mac=${bootif_mac//-/:} >>> + fi >>> + >>> + if [[ -n "${bootif_mac}" ]]; then >>> for i in /sys/class/net/*/address; do >>> read net_mac < ${i} >>> if [[ "${bootif_mac}" == "${net_mac}" ]]; then >>> >> >> If bootit_mac becomes a new cmdline paramteter, please add to docs ;) >> >> Is not a bit redundant? User can set BOOTIF= at syslinux prompt. what is >> the advantage here? > > Thinking about this... Just drop the patch. > It does not matter what format I give to BOOTIF. So I can use the pxelinux > version with hardware type prefix and mac address including dashes: > > BOOTIF=01-88-99-aa-bb-cc-dd > > Or give the mac address directly: > > BOOTIF=88:99:aa:bb:cc:dd > > Right? So I will adjust my boot parameters to always use BOOTIF=. >
Yes, both forms are valid :) The only warning here is when using dash-form, always append 01- first if your MAC start with 01, otherwise will be considered as hardware type [HTYPE] (01 for Ethernet) This is also valid, but not recommended. BOOTIF=88-99-aa-bb-cc-dd
signature.asc
Description: OpenPGP digital signature
