On Oct 23, 2005, at 10:34 PM, Mark Rosenstand wrote:
> Hey Arjan!
>
> On Sun, 23 Oct 2005 15:31:50 +0200, Arjan Timmerman wrote:
>
>> hi all,
>>
>> I spend the last day hacking on gnome-system-tools. the progress is
>> in unstable.
>> at this time the time-admin,services-admin,boot-admin, users-admin
>> are working and supported.
>>
>> known issues:
>>
>> - not every service will show up, this is caused due to our own
>> naming schemes of daemons. if you find one please add a bug report
>> or email me.
>>
>> Please test it, and tell me your troubles with it.
>>
>
> I was looking at your patch, and was wondering what the purpose of
> these assignments are:
>
> RC_INET_CONF => "/etc/rc.d/rc.conf",
> RC_INET => "/etc/rc.d/rc.conf",
> RC_LOCAL => "/etc/rc.d/rc.local",
This is probably related to the network-admin, haven't been working
on it yet.
i just copied the slackware and gave it a bit of another name.
>
> Doesn't those files live in /etc on Arch? Anyway, I was just wondering
> (as it seems to work) :-)
>
> When you parse the rc.conf, you do it by matching the DAEMONS line,
> but FAEMONS, TAEMONS, #AEMONS etc. are matched as well because \D
> means
> any non-digit char. I'm sure you meant to match on /\s*DAEMONS/
hmmm i thought i read that \ was meant as any line that would start
with DAEMONS, but matching it on whitespaces is a nice idea will add
it in the next version.
>
> Another small point of failure is that sh (and hence rc.conf) allows
> line-breaking.
>
> Perhaps it's worth to consider replacing
>
> if(!$active)
> {
> $line =~ s/$script //;
> }
>
> with
>
> $line =~ s/$script\s*// if !$active;
>
> for both better readability and to match 0 or more whitespaces
> instead of just a single space.
>
hmmm i would make it:
> if(!$active)
> {
> $line =~ s/$script\s * //;
> }
I think it is better readable for me and i will need to maintain it ;)
> It's nice to finally see gnome-system-tools on Arch! As you know (if
> you've checked your archlinux.org mailbox in the past week) I'd
> like to
> help out with GNOME. Throw me a message if there's anything I can
> do for
> this particular task. (I'm thinking @daemons, and if g-s-t allows us
> to, maybe even start-up ordering and backgrounding options) :-)
>
yeah, you could pick any of the admins(network,shares,disks) that
aren't ported yet, and please keep reviewing the patches cause it is
my first time touching perl.
I am learning it on the fly :)
> Great work!
>
> --
> .-. Mark Rosenstand (-.)
> oo| cc )
> /`'\ (+45) 255 31337 3-n-(
> (\_;/) [EMAIL PROTECTED] _(|/`->
>
Arjan Timmerman
Archlinux packages Maintainer.
_______________________________________________
arch mailing list
[email protected]
http://www.archlinux.org/mailman/listinfo/arch
