Looks good. If I had to comment, maybe these minor points: - Creating a PR is easiest when you just go to your repository home page on Github after you pushed your branch and it will display a 'Create Pull Request' button for that specific branch. Easy! - Explain the [ci skip] command in commit messages a bit more (Commit Message Format chapter)
Best, Vincent On Tuesday, 16 October 2018 00:37:17 UTC+2, Adam Cox wrote: > > Hello all, > > We have been working on consolidating our instructions for how to > contribute code back to the Arches project. We are pleased to announce that > the guidelines are now ready for you to inspect and comment on. > > Contributing Guidelines: > https://github.com/archesproject/arches/blob/master/CONTRIBUTING.md > Committer Guidelines: > https://github.com/archesproject/arches/wiki/Becoming-a-Committer > > If you are an Arches user who is interested in reporting bugs, suggesting > new features, or someone who has the capacity to contribute code to the > repository, the Contributing Guidelines are where you should start. > > Furthermore, if you are a developer that hopes to eventually gain > "committer" privileges to the main repo (meaning you can merge pull > requests, etc.), please see the Committer Guidelines. > > We are considering both of these documents to be in a "public comment" > phase, where we hope to get feedback from the greater Arches community on > their content. Please reply to this thread, or these github tickets ( > contributor <https://github.com/archesproject/arches/issues/3320>, > committer <https://github.com/archesproject/arches/issues/3321>) with > your thoughts. This phase will last about a month, until the Arches > Technical Training workshop that will take place in Swindon, U.K., from > November 12-15, at which point we will officially adopt them. > > Thanks you for your interest! > > Adam > -- -- To post, send email to [email protected]. To unsubscribe, send email to [email protected]. For more information, visit https://groups.google.com/d/forum/archesproject?hl=en --- You received this message because you are subscribed to the Google Groups "Arches Project" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/d/optout.
