[power-architect commit] r2877 - trunk/src/ca/sqlpower/architect/swingui/action

[codesite-noreply]

Author: jeff...@sqlpower.ca
Date: Mon Dec 15 10:55:31 2008
New Revision: 2877
Modified:
   trunk/src/ca/sqlpower/architect/swingui/action/InsertColumnAction.java

Log:
Fixed a findBugs warning. There was a Possible null pointer dereference  
that was caused by a useless else statement. This was fixed by removing the  
else and throwing a null pointer exception if the variable in question was  
null.

Modified:  
trunk/src/ca/sqlpower/architect/swingui/action/InsertColumnAction.java
==============================================================================
--- trunk/src/ca/sqlpower/architect/swingui/action/InsertColumnAction.java	 
(original)
+++ trunk/src/ca/sqlpower/architect/swingui/action/InsertColumnAction.java	 
Mon Dec 15 10:55:31 2008
@@ -63,10 +63,12 @@
         		logger.debug("did not find column, inserting at start of  
table."); //$NON-NLS-1$
                        idx = 0;
                }
+        }
+        if (st == null) {
+            throw new NullPointerException();
         } else {
-               idx = 0;
+            st.addColumn(idx, new SQLColumn());
         }
-        st.addColumn(idx, new SQLColumn());
         EditColumnAction editColumnAction = new EditColumnAction(session);
         editColumnAction.showDialog(st, idx);