Author: jfuerth
Date: Thu Jun 11 15:34:20 2009
New Revision: 3086
Modified:
trunk/src/ca/sqlpower/architect/swingui/PlayPen.java
Log:
Chipping away at the FindBugs warnings.
Modified: trunk/src/ca/sqlpower/architect/swingui/PlayPen.java
==============================================================================
--- trunk/src/ca/sqlpower/architect/swingui/PlayPen.java (original)
+++ trunk/src/ca/sqlpower/architect/swingui/PlayPen.java Thu Jun 11
15:34:20 2009
@@ -139,13 +139,17 @@
import ca.sqlpower.swingui.ProgressWatcher;
import ca.sqlpower.swingui.SPSwingWorker;
import ca.sqlpower.swingui.dbtree.SQLObjectSelection;
+import edu.umd.cs.findbugs.annotations.SuppressWarnings;
/**
* The PlayPen is the main GUI component of the SQL*Power Architect.
*/
+...@suppresswarnings(
+ justification = "PlayPen is not meant to be serializable",
+ value = {"SE_BAD_FIELD"})
public class PlayPen extends JPanel
- implements java.io.Serializable, SQLObjectListener, SelectionListener,
Scrollable {
+ implements SQLObjectListener, SelectionListener, Scrollable {
public interface CancelableListener {
@@ -1921,7 +1925,7 @@
* at the current mouse position. Also retargets drops to the
* TablePanes when necessary.
*/
- public class PlayPenDropListener implements DropTargetListener {
+ private static class PlayPenDropListener implements DropTargetListener {
/**
* When the user moves over a container pane, its drop target's
@@ -1930,7 +1934,7 @@
* dragExit method will be called, and this variable will
* reference null (or a different table pane).
*/
- protected ContainerPane<?,?> tpTarget;
+ private ContainerPane<?,?> tpTarget;
/**
* Called while a drag operation is ongoing, when the mouse
@@ -2030,8 +2034,6 @@
}
}
-
-
/**
* Called if the user has modified the current drop gesture.
*/
@@ -2228,7 +2230,7 @@
/**
* A nice multi-line translucent label that produces a good drag-and-drop
image.
*/
- private class DnDLabel extends JTextArea {
+ private static class DnDLabel extends JTextArea {
private static final int BORDER_WIDTH = 5;
