[power-architect commit] r3089 - Fixed PMD warning about botched null test. I'm not 100% convinced it was actually incorre...

[codesite-noreply]

Author: jfuerth
Date: Fri Jun 12 13:40:28 2009
New Revision: 3089
Modified:
   trunk/src/ca/sqlpower/architect/swingui/PlayPenComponent.java

Log:
Fixed PMD warning about botched null test. I'm not 100% convinced it was  
actually incorrect before, but the new version of the code definitely reads  
better and definitely works as intended.

Modified: trunk/src/ca/sqlpower/architect/swingui/PlayPenComponent.java
==============================================================================
--- trunk/src/ca/sqlpower/architect/swingui/PlayPenComponent.java       
(original)
+++ trunk/src/ca/sqlpower/architect/swingui/PlayPenComponent.java	Fri Jun  
12 13:40:28 2009
@@ -39,6 +39,7 @@

 import org.apache.log4j.Logger;

+import ca.sqlpower.architect.ArchitectUtils;
 import ca.sqlpower.architect.swingui.event.SelectionEvent;
 import ca.sqlpower.architect.swingui.event.SelectionListener;

@@ -433,12 +434,10 @@
     }

     public void setToolTipText(String toolTipText) {
-        if ((toolTipText == null && this.toolTipText == null)
-                || (toolTipText != null &&  
toolTipText.equals(this.toolTipText))) {
-            return;
+        if (!ArchitectUtils.areEqual(toolTipText, this.toolTipText)) {
+            this.toolTipText = toolTipText;
+            logger.debug("ToolTipText changed to "+toolTipText);  
//$NON-NLS-1$
         }
-        this.toolTipText = toolTipText;
-        logger.debug("ToolTipText changed to "+toolTipText); //$NON-NLS-1$
     }

     public Font getFont() {