Revision: 3607
Author: [email protected]
Date: Fri Jun 11 13:08:26 2010
Log: NEW - bug 2458: Create Critic Manager
http://trillian.sqlpower.ca/bugzilla/show_bug.cgi?id=2458
Added the platform type to the table to easily tell what group the critic
is associated with.
http://code.google.com/p/power-architect/source/detail?r=3607
Modified:
/trunk/src/main/java/ca/sqlpower/architect/swingui/critic/CriticPanel.java
/trunk/src/main/java/ca/sqlpower/architect/swingui/critic/CriticismTableModel.java
=======================================
---
/trunk/src/main/java/ca/sqlpower/architect/swingui/critic/CriticPanel.java
Fri Jun 11 12:29:25 2010
+++
/trunk/src/main/java/ca/sqlpower/architect/swingui/critic/CriticPanel.java
Fri Jun 11 13:08:26 2010
@@ -92,7 +92,7 @@
public CriticPanel(ArchitectSwingSession session) {
this.session = session;
- CriticismTableModel tableModel = new
CriticismTableModel(session.getPlayPen().getCriticismBucket());
+ CriticismTableModel tableModel = new CriticismTableModel(session,
session.getPlayPen().getCriticismBucket());
table = new FancyExportableJTable(tableModel);
table.setDefaultRenderer(Severity.class, tableRenderer);
panel = new JPanel(new BorderLayout());
=======================================
---
/trunk/src/main/java/ca/sqlpower/architect/swingui/critic/CriticismTableModel.java
Wed Jun 9 11:52:17 2010
+++
/trunk/src/main/java/ca/sqlpower/architect/swingui/critic/CriticismTableModel.java
Fri Jun 11 13:08:26 2010
@@ -21,11 +21,13 @@
import javax.swing.table.AbstractTableModel;
+import ca.sqlpower.architect.ddl.critic.CriticAndSettings;
import ca.sqlpower.architect.ddl.critic.Criticism;
import ca.sqlpower.architect.ddl.critic.CriticismBucket;
import ca.sqlpower.architect.ddl.critic.CriticismEvent;
import ca.sqlpower.architect.ddl.critic.CriticismListener;
import ca.sqlpower.architect.ddl.critic.CriticAndSettings.Severity;
+import ca.sqlpower.architect.swingui.ArchitectSwingSession;
public class CriticismTableModel extends AbstractTableModel {
@@ -42,13 +44,16 @@
}
};
- public CriticismTableModel(CriticismBucket criticizer) {
+ private final ArchitectSwingSession session;
+
+ public CriticismTableModel(ArchitectSwingSession session,
CriticismBucket criticizer) {
+ this.session = session;
this.criticizer = criticizer;
criticizer.addCriticismListener(criticListener);
}
public int getColumnCount() {
- return 3;
+ return 4;
}
@Override
@@ -56,6 +61,8 @@
if (column == 1) {
return "Object";
} else if (column == 2) {
+ return "Critic Type";
+ } else if (column == 3) {
return "Description";
} else {
return null;
@@ -70,6 +77,8 @@
return String.class;
} else if (columnIndex == 2) {
return String.class;
+ } else if (columnIndex == 3) {
+ return String.class;
} else {
return null;
}
@@ -86,6 +95,11 @@
} else if (columnIndex == 1) {
return rowVal.getSubject();
} else if (columnIndex == 2) {
+ //All critics in Architect are currently CriticAndSettings
objects
+ //In the future we may want to look up the settings in the
critic
+ //manager but since we already have the object that would be
overkill.
+ return ((CriticAndSettings)
rowVal.getCritic()).getPlatformType();
+ } else if (columnIndex == 3) {
return rowVal.getDescription();
} else {
throw new IllegalArgumentException(