Revision: 3640
Author: [email protected]
Date: Fri Jun 25 12:04:13 2010
Log: NEW - bug 2458: Create Critic Manager
http://trillian.sqlpower.ca/bugzilla/show_bug.cgi?id=2458
Externalized more strings.
http://code.google.com/p/power-architect/source/detail?r=3640
Modified:
/trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/AlphaNumericNameCritic.java
/trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/AlphaNumericSequenceNameCritic.java
/trunk/src/main/resources/ca/sqlpower/architect/ddl/critic/impl/messages.properties
=======================================
---
/trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/AlphaNumericNameCritic.java
Mon Jun 14 07:57:56 2010
+++
/trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/AlphaNumericNameCritic.java
Fri Jun 25 12:04:13 2010
@@ -31,7 +31,7 @@
super(StarterPlatformTypes.GENERIC.getName(),
Pattern.compile("^[a-z_][a-z0-9_]*$",
Pattern.CASE_INSENSITIVE),
Integer.MAX_VALUE);
- setName("Non-alpha-numeric physical names");
+ setName(Messages.getString("AlphaNumericNameCritic.name"));
}
}
=======================================
---
/trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/AlphaNumericSequenceNameCritic.java
Mon Jun 14 08:22:05 2010
+++
/trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/AlphaNumericSequenceNameCritic.java
Fri Jun 25 12:04:13 2010
@@ -37,7 +37,7 @@
private final Pattern pattern = Pattern.compile("^[a-z_][a-z0-9_]*$",
Pattern.CASE_INSENSITIVE);
public AlphaNumericSequenceNameCritic() {
- super(StarterPlatformTypes.GENERIC.getName(), "Non-alpha-numeric
sequence names");
+ super(StarterPlatformTypes.GENERIC.getName(),
Messages.getString("AlphaNumericSequenceNameCritic.name"));
}
public List<Criticism> criticize(Object subject) {
@@ -52,7 +52,7 @@
if (!pattern.matcher(physName).matches()) {
criticisms.add(new Criticism(
so,
- "Sequence name not legal for column " + so.getName(),
+
Messages.getString("AlphaNumericSequenceNameCritic.quickFixMessage",
so.getName()),
this
));
}
=======================================
---
/trunk/src/main/resources/ca/sqlpower/architect/ddl/critic/impl/messages.properties
Fri Jun 25 11:31:05 2010
+++
/trunk/src/main/resources/ca/sqlpower/architect/ddl/critic/impl/messages.properties
Fri Jun 25 12:04:13 2010
@@ -2,6 +2,9 @@
Column=Column
Relationship=Relationship
Index=Index
+AlphaNumericNameCritic.name=Warns on non-alpha-numeric physical names.
+AlphaNumericSequenceNameCritic.name=Warns on non-alpha-numeric sequence
names.
+AlphaNumericSequenceNameCritic.quickFixMessage=Sequence name not legal for
column {0}.
MySQLReservedWordsCritic.name=Warns when objects are named reserved words
in MySQL.
OracleReservedWordsCritic.name=Warns when objects are named reserved words
in Oracle.
PostgreSQLReservedWordsCritic.name=Warns when objects are named reserved
words in PostgreSQL.
