Revision: 3727
Author: [email protected]
Date: Tue Jul 13 15:38:56 2010
Log: NEW - bug 2458: Create Critic Manager
http://trillian.sqlpower.ca/bugzilla/show_bug.cgi?id=2458

The invalid driver critic is now part of a new group of critics for configuration problems. These types of critics can only be set to error or ignored.
http://code.google.com/p/power-architect/source/detail?r=3727

Modified:
/trunk/src/main/java/ca/sqlpower/architect/ddl/critic/CriticAndSettings.java /trunk/src/main/java/ca/sqlpower/architect/swingui/critic/CriticSettingsPanel.java

=======================================
--- /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/CriticAndSettings.java Thu Jul 8 14:01:17 2010 +++ /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/CriticAndSettings.java Tue Jul 13 15:38:56 2010
@@ -71,7 +71,14 @@
         ORACLE("Oracle", OracleDDLGenerator.class),
         DB2("DB2", DB2DDLGenerator.class),
         H2("H2", H2DDLGenerator.class),
-        HSQLDB("HSQLDB", HSQLDBDDLGenerator.class);
+        HSQLDB("HSQLDB", HSQLDBDDLGenerator.class),
+        /**
+         * All configuration critics can belong to this group. These errors
+         * are in a special class because they are not model specific and
+         * you may have errors when connecting or forward engineering.
+         * Configuration critics also should not be set to a warning.
+         */
+        CONFIGURATION("Configuration", DDLGenerator.class);

         /**
* Human readable group name of the platform type which the critics using will
=======================================
--- /trunk/src/main/java/ca/sqlpower/architect/swingui/critic/CriticSettingsPanel.java Tue Jul 6 15:01:13 2010 +++ /trunk/src/main/java/ca/sqlpower/architect/swingui/critic/CriticSettingsPanel.java Tue Jul 13 15:38:56 2010
@@ -30,6 +30,7 @@

 import ca.sqlpower.architect.ddl.critic.CriticAndSettings;
 import ca.sqlpower.architect.ddl.critic.CriticAndSettings.Severity;
+import ca.sqlpower.architect.ddl.critic.CriticAndSettings.StarterPlatformTypes;
 import ca.sqlpower.object.AbstractSPListener;
 import ca.sqlpower.object.SPListener;
 import ca.sqlpower.swingui.DataEntryPanel;
@@ -86,6 +87,9 @@

         panel = new JPanel();
         severityCombo = new JComboBox(Severity.values());
+ if (settings.getPlatformType().equals(StarterPlatformTypes.CONFIGURATION.getName())) {
+            severityCombo.removeItem(Severity.WARNING);
+        }
         severityCombo.setSelectedItem(settings.getSeverity());
//It would be nice if the layout used a pref:grow style for the first //column but it makes it difficult to set the preferred size correctly.

Reply via email to