[power-architect] r3778 committed - Externalized the names of the existing critics and updated them to rea...

Thu, 22 Jul 2010 11:22:18 -0700 

Revision: 3778
Author: [email protected]
Date: Thu Jul 22 11:20:52 2010
Log: Externalized the names of the existing critics and updated them to read better than they did previously. 
http://code.google.com/p/power-architect/source/detail?r=3778

Modified:
/trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/CommentCritic.java /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/DuplicateNameCritic.java /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/EmptyRelationshipCritic.java /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/PhysicalNameCritic.java /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/PrimaryKeyCritic.java /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/RelationshipMappingTypeCritic.java /trunk/src/main/resources/ca/sqlpower/architect/ddl/critic/impl/messages.properties 

=======================================
--- /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/CommentCritic.java Wed Jul 14 07:10:07 2010 +++ /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/CommentCritic.java Thu Jul 22 11:20:52 2010 
@@ -44,7 +44,7 @@
@ConstructorParameter(propertyName="platformName") String platformName, @ConstructorParameter(propertyName="maxTableCommentLength") int maxLengthTable, @ConstructorParameter(propertyName="maxColumnCommentLength")int maxLengthColumn) { 
-        super(platformName, "Comment restriction critic");
+        super(platformName, Messages.getString("CommentCritic.name"));
         this.platformName = platformName;
         this.maxColumnCommentLength = maxLengthColumn;
         this.maxTableCommentLength = maxLengthTable;
=======================================
--- /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/DuplicateNameCritic.java Wed Jul 14 11:39:12 2010 +++ /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/DuplicateNameCritic.java Thu Jul 22 11:20:52 2010 
@@ -66,7 +66,7 @@
private Multimap<SQLTable, SQLColumn> columnPhysicalNameMap = ArrayListMultimap.create(); 

     public DuplicateNameCritic() {
- super(StarterPlatformTypes.GENERIC.getName(), "Error on objects with the same name."); + super(StarterPlatformTypes.GENERIC.getName(), Messages.getString("DuplicateNameCritic.name")); 
     }

     @Override
=======================================
--- /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/EmptyRelationshipCritic.java Mon Jun 14 07:39:24 2010 +++ /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/EmptyRelationshipCritic.java Thu Jul 22 11:20:52 2010 
@@ -32,7 +32,7 @@
 public class EmptyRelationshipCritic extends CriticAndSettings {

     public EmptyRelationshipCritic() {
- super(StarterPlatformTypes.GENERIC.getName(), "Empty relationships"); + super(StarterPlatformTypes.GENERIC.getName(), Messages.getString("EmptyRelationshipCritic.name")); 
     }

     public List<Criticism> criticize(Object subject) {
=======================================
--- /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/PhysicalNameCritic.java Wed Jul 14 07:10:07 2010 +++ /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/PhysicalNameCritic.java Thu Jul 22 11:20:52 2010 
@@ -68,7 +68,7 @@
@ConstructorParameter(propertyName="platformName") String platformName, @ConstructorParameter(propertyName="legalNamePattern") Pattern legalNamePattern, @ConstructorParameter(propertyName="maxNameLength") int maxNameLength) { 
-        super(platformName, "Physical name restrictions");
+        super(platformName, Messages.getString("PhysicalNameCritic.name"));
         this.platformName = platformName;
         this.legalNamePattern = legalNamePattern;
         this.maxNameLength = maxNameLength;
=======================================
--- /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/PrimaryKeyCritic.java Wed Jun 9 12:05:56 2010 +++ /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/PrimaryKeyCritic.java Thu Jul 22 11:20:52 2010 
@@ -32,7 +32,7 @@
 public class PrimaryKeyCritic extends CriticAndSettings {

     public PrimaryKeyCritic() {
-        super(StarterPlatformTypes.GENERIC.getName(), "Empty primary key");
+ super(StarterPlatformTypes.GENERIC.getName(), Messages.getString("PrimaryKeyCritic.name")); 
     }

     public List<Criticism> criticize(final Object so) {
=======================================
--- /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/RelationshipMappingTypeCritic.java Wed Jul 14 07:10:07 2010 +++ /trunk/src/main/java/ca/sqlpower/architect/ddl/critic/impl/RelationshipMappingTypeCritic.java Thu Jul 22 11:20:52 2010 
@@ -41,7 +41,7 @@
 public class RelationshipMappingTypeCritic extends CriticAndSettings {

     public RelationshipMappingTypeCritic() {
- super(StarterPlatformTypes.GENERIC.getName(), "Relationships map columns of different types"); + super(StarterPlatformTypes.GENERIC.getName(), Messages.getString("RelationshipMappingTypeCritic.name")); 
     }

     public List<Criticism> criticize(Object so) {
=======================================
--- /trunk/src/main/resources/ca/sqlpower/architect/ddl/critic/impl/messages.properties Mon Jun 28 11:53:08 2010 +++ /trunk/src/main/resources/ca/sqlpower/architect/ddl/critic/impl/messages.properties Thu Jul 22 11:20:52 2010 
@@ -2,23 +2,29 @@
 Column=Column
 Relationship=Relationship
 Index=Index
-AlphaNumericNameCritic.name=Warns on non-alpha-numeric physical names.
-AlphaNumericSequenceNameCritic.name=Warns on non-alpha-numeric sequence names. 
+AlphaNumericNameCritic.name=Checks for non-alpha-numeric physical names.
+AlphaNumericSequenceNameCritic.name=Checks for non-alpha-numeric sequence names. AlphaNumericSequenceNameCritic.quickFixMessage=Sequence name not legal for column {0}. -UnsupportedFeaturesCritic.deferrabilityRuleNotSupported={0} does not support {1}'s deferrability action. -UnsupportedFeaturesCritic.deleteRuleNotSupported={0} does not support {1}'s delete action. -UnsupportedFeaturesCritic.name=Warns when using features not supported by {0}. -UnsupportedFeaturesCritic.updateRuleNotSupported={0} does not support {1}'s update action. -MySQLReservedWordsCritic.name=Warns when objects are named reserved words in MySQL. -OracleReservedWordsCritic.name=Warns when objects are named reserved words in Oracle. -PostgreSQLReservedWordsCritic.name=Warns when objects are named reserved words in PostgreSQL. +CommentCritic.name=Checks for comments that are larger than the allowed length. 
+DuplicateNameCritic.name=Checks for objects with the same name.
+EmptyRelationshipCritic.name=Checks for relationships that do not map any columns. +MySQLReservedWordsCritic.name=Checks for objects that are named reserved words in MySQL. +OracleReservedWordsCritic.name=Checks for objects that are named reserved words in Oracle. +PhysicalNameCritic.name=Checks for physical names that are larger than the allowed length. +PostgreSQLReservedWordsCritic.name=Checks for objects that are named reserved words in PostgreSQL. 
+PrimaryKeyCritic.name=Checks for tables with an empty primary key.
+RelationshipMappingTypeCritic.name=Checks for relationships that map columns of different types. ReservedWordsCritic.criticismDesc={0} named {1} is a reserved word. Please change the name. 
 ReservedWordsCritic.quickFixDesc=Change the name to {0}.
SetDefaultOnColumnWithNoDefaultCritic.deleteRuleCriticism=SET DEFAULT delete action in relationship {0} references column {1} with no default value. -SetDefaultOnColumnWithNoDefaultCritic.name=Warns on relationships using default rules and maps columns with no defaults. +SetDefaultOnColumnWithNoDefaultCritic.name=Checks for relationship that use default rules and maps columns with no defaults. SetDefaultOnColumnWithNoDefaultCritic.updateRuleCriticism=SET DEFAULT update action in relationship {0} references column {1} with no default value. SetNullOnNonNullableColumnCritic.deleteRuleCriticism=SET NULL delete action in relationship {0} references non-nullable column {1}. -SetNullOnNonNullableColumnCritic.name=Warns on relationships using null rules and maps columns that are non-null. +SetNullOnNonNullableColumnCritic.name=Checks for relationships that use null rules and maps columns that are non-null. 
 SetNullOnNonNullableColumnCritic.quickFix=Make {0} nullable.
SetNullOnNonNullableColumnCritic.updateRuleCriticism=SET NULL update action in relationship {0} references non-nullable column {1}. -SQLServerReservedWordsCritic.name=Warns when objects are named reserved words in SQL Server. +SQLServerReservedWordsCritic.name=Checks for objects that are named reserved words in SQL Server. +UnsupportedFeaturesCritic.deferrabilityRuleNotSupported={0} does not support {1}'s deferrability action. +UnsupportedFeaturesCritic.deleteRuleNotSupported={0} does not support {1}'s delete action. +UnsupportedFeaturesCritic.name=Checks for objects using features not supported by {0}. +UnsupportedFeaturesCritic.updateRuleNotSupported={0} does not support {1}'s update action.

Reply via email to