Hi All, Sorry I have been distracted and could not catch up back on the object database thread, will do so very soon. Meanwhile, would like to request some feedback on the theft interfaces
Hi Eran, The data model is near to complete for a first draft, but the API itself is half-baked and the feedback you have below is already useful. I will request for a API thrift IDL review later this week. Meanwhile, you have any feedback on the data model thrift IDL - https://git-wip-us.apache.org/repos/asf?p=airavata.git;a=blob_plain;f=airavata-api/thrift-interface-descriptions/experimentModel.thrift;hb=HEAD Thanks, Suresh On Feb 24, 2014, at 1:40 AM, Eran Chinthaka Withana <[email protected]> wrote: > Comments on thrift IDL > > 1. The input and output parameters do not have constraint specifiers > (required vs optional) and left to be default. This will be very > challenging when we try to improve APIs in later versions and its a > standard practise to ALWAYS have either optional or required as constraint > specifiers. > > 2. consider using TypeDefs to reduce repetitive names. For example, > defining airavataErrors.InvalidRequestException as a type will help you to > simply refer to that as InvalidRequestException > > 3. Introduce a parameter for each method to get the API key. This will be > helpful in the future to identify individual clients, enforce SLAs, logs > requests, etc
