All, Part of the work to remove the environment reporter (GPII-3117 [1]) and modify the ContextManager involves removing the code that handles the "conditions:" blocks within the preferences.
Since those blocks will be ignored by the system, it might be appropriate to remove them from our canned preferences. An example can be seen here in "condTest.json5": https://github.com/GPII/universal/blob/master/testData/preferences/condTest.json5#L36 The reason to remove them is their presence implies that they have an affect on the system. That's no longer the case since they are no longer processed. Their absence is more reflective of the actual situation. However, before removing them, I want to alert others of the plan to see if these "conditions:" blocks are needed for anything that you are working on. Most of these preferences are the basis for the 'snapset' preferences preloaded into the database by the dataloader. Following is a list of the affected preferences sets. Note that *none* of the "snapset_x" preferences are affected by this change (e.g., "snapset_1a"): - contTest - condTest2 - li - manuel - multi_context - vladimir I have found one one other set in the tests folder specifically for testing conditions (tests/data/preferences/context1.json5). [1] https://issues.gpii.net/browse/GPII-3117 -- ;;;;joseph. 'The only reason for time is so that everything doesn't happen all at once.' - B. Banzai - _______________________________________________ Architecture mailing list [email protected] https://lists.gpii.net/mailman/listinfo/architecture
