On Mon, Apr 29, 2013 at 8:21 PM, Nirmal Fernando <[email protected]> wrote:

> Is there a way to revert all the applied patches? If so, do you handle
> that scenario? I'd love to see the patches that are been reverted too, in
> logs.
>

if you delete the patches and restart the server that will basically copy
the content of patch0000 to plugins folder.

thanks,
Amila.

>
>
> On Mon, Apr 29, 2013 at 7:31 PM, Shameera Rathnayaka <[email protected]>wrote:
>
>> Hi ,
>>
>> According to the provided patch it will always provide the warning when
>> user start server without -DapplyPatches, Yes this is bit odd.
>>
>> Assuming that we always encourage client to replace the full patch
>> directory not part of it, As Azeez mentioned we can keep the names of
>> installed patch directories in a local file. When user restart the server
>> without -DapplyPatches we can check available patch directory names with
>> stored names and print a warning if there are new patches.
>>
>> There may be a situation mistakenly user has replaced a corrupted jar
>> with a jar in plugins directory. This can solve by restart server with
>> -DapplyPatches again.Generating md5 is may be the perfect way to do this
>> but IMO above approach is simple than it and cover the all our
>> requirements.
>>
>> If you all agree with above approach i will update my patch according to
>> it, BTW we will have a option to ignore this check.
>>
>> Thanks,
>> Shameera.
>>
>>
>> On Mon, Apr 29, 2013 at 6:39 PM, Afkham Azeez <[email protected]> wrote:
>>
>>> Also, please make it possible to turn this off. The default behavior
>>> could be that patch information is printed, but this can have a significant
>>> impact on startup time on resource constrained environments. So, please
>>> provide a System property which will make it possible to turn this off.
>>>
>>> Azeez
>>>
>>>
>>> On Mon, Apr 29, 2013 at 6:32 PM, Srinath Perera <[email protected]>wrote:
>>>
>>>> or you should do the MD5 against the patch jar and the corresponding
>>>> counterpart in the plugin directory as per our chat.
>>>>
>>>> what azeez said works as well.
>>>>
>>>> --Srinath
>>>>
>>>>
>>>> On Mon, Apr 29, 2013 at 4:59 PM, Afkham Azeez <[email protected]> wrote:
>>>>
>>>>>
>>>>>
>>>>> On Mon, Apr 29, 2013 at 4:51 PM, Shameera Rathnayaka <
>>>>> [email protected]> wrote:
>>>>>
>>>>>> Hi all,
>>>>>>
>>>>>> According to the discussion, I have attached a patch for this. With
>>>>>> this patch, when user runs the server with -DapplyPatches it will
>>>>>> print applying patches info like below
>>>>>>  INFO {org.wso2.carbon.server.util.Utils} -  applying patch :
>>>>>> patch0001
>>>>>> INFO {org.wso2.carbon.server.util.Utils} -  applying patch : patch0002
>>>>>> INFO {org.wso2.carbon.server.util.Utils} -  applying patch : patch0003
>>>>>>
>>>>>> if user didn't use the -DapplyPatches option and patches are
>>>>>> available in repository/component/patches directory then it will print a
>>>>>> warning
>>>>>>
>>>>>> WARN {org.wso2.carbon.server.extensions.PatchInstaller} -  Patches
>>>>>> available under patches directory
>>>>>>
>>>>>
>>>>> What happens if the user first applies patches, starts with
>>>>> -DapplyPatches, then restarts without -DapplyPatches? Do you still get a
>>>>> WARNing log? If some patches were applied but later the user copies a few
>>>>> new patches, but doesn't run -DapplyPatches, does the WARNing message only
>>>>> print the list of patches that was not applied?
>>>>>
>>>>> In order to implement the above, you may have to maintain the patch
>>>>> application status in the local file system or local registry.
>>>>>
>>>>>
>>>>>>
>>>>>> logs are print in both terminal and patches.log
>>>>>>
>>>>>>
>>>>>> Thanks
>>>>>> Shameera.
>>>>>>
>>>>>>
>>>>>> On Tue, Apr 23, 2013 at 9:53 AM, Afkham Azeez <[email protected]> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Mon, Apr 22, 2013 at 5:31 PM, Pradeep Fernando 
>>>>>>> <[email protected]>wrote:
>>>>>>>
>>>>>>>> The new carbon servers will have the -Dapplypatches behaviour by
>>>>>>>> default. (startup scripts will have that). Hence not sure about the
>>>>>>>> validity of that use case.
>>>>>>>>
>>>>>>>
>>>>>>> That is not good. You don't  need to apply patches always. This
>>>>>>> unnecessarily would eat of some of the startup time. In resource
>>>>>>> constrained environments, this would translate into a bigger startup 
>>>>>>> delay.
>>>>>>> I don't see why this is being done. If patches are to be applied, the 
>>>>>>> user
>>>>>>> can consciously do it or script it.
>>>>>>>
>>>>>>>
>>>>>>>>
>>>>>>>> --Pradeep
>>>>>>>>
>>>>>>>>
>>>>>>>> On Mon, Apr 22, 2013 at 4:50 PM, Shameera Rathnayaka <
>>>>>>>> [email protected]> wrote:
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> According to the offline chat with Srinath, one use case is, When
>>>>>>>>> user start the server without -DapplyPatches option, But user has 
>>>>>>>>> added a
>>>>>>>>> new patch directory(let say patch0005) to the patches 
>>>>>>>>> directory(assume user
>>>>>>>>> has already started the server with -DapplyPatches option before 
>>>>>>>>> adding new
>>>>>>>>> patch directory). Then proper warning message should print in server
>>>>>>>>> startup console.
>>>>>>>>>
>>>>>>>>> Here we can only compare md5 checksum of jars at the latest patch
>>>>>>>>> directory(patch0005) with jars at repository/component/plugins 
>>>>>>>>> directory to
>>>>>>>>> detect this situation.
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Shameera.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Thu, Apr 18, 2013 at 6:32 PM, Amila Suriarachchi <
>>>>>>>>> [email protected]> wrote:
>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Sat, Apr 6, 2013 at 12:55 PM, Srinath Perera <[email protected]
>>>>>>>>>> > wrote:
>>>>>>>>>>
>>>>>>>>>>> Lets print following information when starting the server
>>>>>>>>>>>
>>>>>>>>>>> 1. current patch level
>>>>>>>>>>> 2. check the md5 for the most current patch and corresponding
>>>>>>>>>>> jar and print a warning.
>>>>>>>>>>>
>>>>>>>>>>> Currently QA team manually verify these every time they start
>>>>>>>>>>> the server. We can automate them.
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> I am wondering how many times QA team has found that there is a
>>>>>>>>>> difference between the latest patched jars and jars in the plugins 
>>>>>>>>>> folder
>>>>>>>>>> after starting the server with -DapplyPatches?
>>>>>>>>>>
>>>>>>>>>> thanks,
>>>>>>>>>> Amila.
>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --Srinath
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> ============================
>>>>>>>>>>> Srinath Perera, Ph.D.
>>>>>>>>>>>   Senior Software Architect, WSO2 Inc.
>>>>>>>>>>>   Visiting Faculty, University of Moratuwa
>>>>>>>>>>>   Member, Apache Software Foundation
>>>>>>>>>>>   Research Scientist, Lanka Software Foundation
>>>>>>>>>>>   Blog: http://srinathsview.blogspot.com/
>>>>>>>>>>>   Photos: http://www.flickr.com/photos/hemapani/
>>>>>>>>>>>  Phone: 0772360902
>>>>>>>>>>>
>>>>>>>>>>> _______________________________________________
>>>>>>>>>>> Architecture mailing list
>>>>>>>>>>> [email protected]
>>>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> *Amila Suriarachchi*
>>>>>>>>>>
>>>>>>>>>> Software Architect
>>>>>>>>>> WSO2 Inc. ; http://wso2.com
>>>>>>>>>> lean . enterprise . middleware
>>>>>>>>>>
>>>>>>>>>> phone : +94 71 3082805
>>>>>>>>>>
>>>>>>>>>> _______________________________________________
>>>>>>>>>> Architecture mailing list
>>>>>>>>>> [email protected]
>>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> *Software Engineer - WSO2 Inc.*
>>>>>>>>> *email: [email protected]*
>>>>>>>>> *phone:  +9471 922 1454*
>>>>>>>>> *
>>>>>>>>> *
>>>>>>>>> *Linked in : *
>>>>>>>>> http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561
>>>>>>>>> *Twitter     : *https://twitter.com/Shameera_R
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> Architecture mailing list
>>>>>>>>> [email protected]
>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> *Pradeep Fernando*
>>>>>>>> Member, Management Committee - Platform & Cloud Technologies
>>>>>>>> Senior Software Engineer;WSO2 Inc.; http://wso2.com
>>>>>>>>
>>>>>>>> blog: http://pradeepfernando.blogspot.com
>>>>>>>> m: +94776603662
>>>>>>>>
>>>>>>>> _______________________________________________
>>>>>>>> Architecture mailing list
>>>>>>>> [email protected]
>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>>>>>
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> *Afkham Azeez*
>>>>>>> Director of Architecture; WSO2, Inc.; http://wso2.com
>>>>>>> Member; Apache Software Foundation; http://www.apache.org/
>>>>>>> * <http://www.apache.org/>**
>>>>>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
>>>>>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
>>>>>>> twitter: 
>>>>>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>>>>>>> *
>>>>>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>>>>>>> *
>>>>>>> *
>>>>>>> *Lean . Enterprise . Middleware*
>>>>>>>
>>>>>>> _______________________________________________
>>>>>>> Architecture mailing list
>>>>>>> [email protected]
>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>>>>
>>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> *Software Engineer - WSO2 Inc.*
>>>>>> *email: shameera AT wso2.com <[email protected]> , shameera AT
>>>>>> apache.org <[email protected]>*
>>>>>>  *phone:  +9471 922 1454*
>>>>>> *
>>>>>> *
>>>>>> *Linked in : *
>>>>>> http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561
>>>>>> *Twitter     : *https://twitter.com/Shameera_R
>>>>>>
>>>>>> _______________________________________________
>>>>>> Architecture mailing list
>>>>>> [email protected]
>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Afkham Azeez*
>>>>> Director of Architecture; WSO2, Inc.; http://wso2.com
>>>>> Member; Apache Software Foundation; http://www.apache.org/
>>>>> * <http://www.apache.org/>**
>>>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
>>>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
>>>>> twitter: 
>>>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>>>>> *
>>>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>>>>> *
>>>>> *
>>>>> *Lean . Enterprise . Middleware*
>>>>>
>>>>> _______________________________________________
>>>>> Architecture mailing list
>>>>> [email protected]
>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> ============================
>>>> Srinath Perera, Ph.D.
>>>>   Senior Software Architect, WSO2 Inc.
>>>>   Visiting Faculty, University of Moratuwa
>>>>   Member, Apache Software Foundation
>>>>   Research Scientist, Lanka Software Foundation
>>>>   Blog: http://srinathsview.blogspot.com/
>>>>   Photos: http://www.flickr.com/photos/hemapani/
>>>>  Phone: 0772360902
>>>>
>>>> _______________________________________________
>>>> Architecture mailing list
>>>> [email protected]
>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>
>>>>
>>>
>>>
>>> --
>>> *Afkham Azeez*
>>> Director of Architecture; WSO2, Inc.; http://wso2.com
>>> Member; Apache Software Foundation; http://www.apache.org/
>>> * <http://www.apache.org/>**
>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
>>> twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>>> *
>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>>> *
>>> *
>>> *Lean . Enterprise . Middleware*
>>>
>>> _______________________________________________
>>> Architecture mailing list
>>> [email protected]
>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>
>>>
>>
>>
>> --
>> *Software Engineer - WSO2 Inc.*
>> *email: shameera AT wso2.com <[email protected]> , shameera AT 
>> apache.org<[email protected]>
>> *
>> *phone:  +9471 922 1454*
>> *
>> *
>> *Linked in : *http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561
>> *Twitter     : *https://twitter.com/Shameera_R
>>
>> _______________________________________________
>> Architecture mailing list
>> [email protected]
>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>
>>
>
>
> --
>
> Thanks & regards,
> Nirmal
>
> Software Engineer- Platform Technologies Team, WSO2 Inc.
> Mobile: +94715779733
> Blog: http://nirmalfdo.blogspot.com/
>
> <http://nirmalfdo.blogspot.com/>
>
> _______________________________________________
> Architecture mailing list
> [email protected]
> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>
>


-- 
*Amila Suriarachchi*

Software Architect
WSO2 Inc. ; http://wso2.com
lean . enterprise . middleware

phone : +94 71 3082805
_______________________________________________
Architecture mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture

Reply via email to