On Jun 18, 2013 7:35 AM, "Amila Suriarachchi" <[email protected]> wrote: > > > > > On Mon, Jun 17, 2013 at 7:15 AM, Sriskandarajah Suhothayan <[email protected]> wrote: >> >> >> >> >> On Mon, Jun 17, 2013 at 6:10 PM, Geeth Munasinghe <[email protected]> wrote: >>> >>> HI >>> >>> In code review of "AS Webapp Staitistic Publishing to BAM" discussed moving the following class[1] in to the data-bridge to be used as a single api. The reason this code will be repeated in web app statistic publishing component also. >> >> >> +1 for Moving webapp publishing to data-agents >> >> but its not appropriate adding it to the org.wso2.carbon.bam.service.data.publisher, rather it has to become a component in data-agents as >> org.wso2.carbon.webapp.data.publisher > > > Some of the code in this class is not specific to the webapp data publisher. For an example data bridge component should have method where all the other publishers can pass the objects lists of each event types, configuration and agent configuration. Each an every publisher does not have to care about whether it is a load balancing endpoint etc ..
+1 we need to improve the data publisher API to handle endpoints configuration internally I'll review the code and will do the necessary changes Suho > Another thing I saw in both stat data publisher and web app publisher UI is BAM agent configuration is repeating. We need to rethink about them and refactor data publisher accordingly. > > thanks, > Amila. > >> >> >> Regards >> Suho >> >>> >>> >>> [1] https://svn.wso2.org/repos/wso2/carbon/platform/trunk/components/data-agents/org.wso2.carbon.bam.service.data.publisher/src/main/java/org/wso2/carbon/bam/service/data/publisher/publish/EventPublisher.java >>> >>> Please give your comments. >>> >>> Thanks >>> >>> >>> >>> >>> G. K. S. Munasinghe >>> Software Engineer, >>> WSO2, Inc. http://wso2.com >>> lean.enterprise.middleware. >>> >>> email: [email protected] >>> phone:(+94) 777911226 >>> >>> _______________________________________________ >>> Architecture mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >> >> >> >> -- >> S. Suhothayan >> Associate Technical Lead, >> Management Committee Member, Data Technologies Team, >> WSO2 Inc. http://wso2.com >> lean . enterprise . middleware >> >> cell: (+94) 779 756 757 | blog: http://suhothayan.blogspot.com/ >> twitter: http://twitter.com/suhothayan | linked-in: http://lk.linkedin.com/in/suhothayan >> > > > > -- > Amila Suriarachchi > > Software Architect > > WSO2 Inc. ; http://wso2.com > lean . enterprise . middleware > > phone : +94 71 3082805
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
