Hi Sameera,

I used that kind of package structure, FQN of action class is
org.wso2.carbon.p2.touchpoint.actions.xml.AddElementAction, yes we can
change the action name too,

On Wed, Jul 10, 2013 at 2:48 PM, Sameera Jayasoma <[email protected]> wrote:

> Hi Shameera,
>
> IMHO, addElement is a generic action name. How about having actions names
> like.
>
> addXMLElement
> removeXMLElement
> replaceXMLElement
>

Are you suggesting to use two touchpoints here to add xml element and
remove xml element ? I haven't check it but there is undo concept as i
mentioned in my previous reply we can use that too.

Thanks,
Shameera.



>
> Because in the future we may need support updating config files which are
> in non-XML format.
>
>
> On Tue, Jul 9, 2013 at 8:51 PM, Shameera Rathnayaka <[email protected]>wrote:
>
>> Hi All,
>>
>> As the requirement is to add another xml element to a existing xml file,I
>> have implemented a new touchpoint (AddElementAction) to edit xml file by
>> giving xpath and element which need to be added to given xpath. As same as
>> eclipse and native toucpoints, you can use this with p2.inf file. Following
>> is an example configuration which need to go to p2.inf file.
>>
>>  eg:   instructions.configure =
>> org.wso2.carbon.p2.touchpoint.addElement(file:/path/to/xml/file,xpath:/xpath/to/the/location,element:<node>value</node>);
>> \
>>
>> Thanks,
>> Shameera.
>>
>>
>>
>>
>> On Tue, Jun 25, 2013 at 1:49 PM, Sameera Jayasoma <[email protected]>wrote:
>>
>>> +1. This can be done by utilizing an existing touchpoint in P2, if any.
>>> Otherwise we have to write a new touchpoint.
>>>
>>> Thanks,
>>> Sameera.
>>>
>>>
>>> On Tue, Jun 25, 2013 at 1:39 PM, Paul Fremantle <[email protected]> wrote:
>>>
>>>> That seems like a cool solution. +1.
>>>>
>>>> Paul
>>>>
>>>>
>>>> On 25 June 2013 09:05, Pradeep Fernando <[email protected]> wrote:
>>>>
>>>>> Hi Paul,
>>>>>
>>>>> There are some inbuilt functions like, copy/mv/delete resources.
>>>>> However they don't provide a file-edit touchpoint by default. In that case
>>>>> we have to write one. (your custom code running requirement can be met
>>>>> using the same mechanism..)
>>>>>
>>>>> --Pradeep
>>>>>
>>>>>
>>>>> On Tue, Jun 25, 2013 at 1:25 PM, Paul Fremantle <[email protected]> wrote:
>>>>>
>>>>>> Isn't there some way we can run some code on adding the p2 features
>>>>>> that will do the config?
>>>>>>
>>>>>> Paul
>>>>>>
>>>>>>
>>>>>> On 25 June 2013 08:38, Supun Malinga <[email protected]> wrote:
>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> On Tue, Jun 25, 2013 at 1:03 PM, Paul Fremantle <[email protected]>wrote:
>>>>>>>
>>>>>>>> Sameera
>>>>>>>>
>>>>>>>> I'm kind of -0 on this plan. Adding manual steps where people can
>>>>>>>> make mistakes reduces the usability of the product. I'm also concerned 
>>>>>>>> by
>>>>>>>> the size growth, but if you put this in terms of ease of use and time 
>>>>>>>> then
>>>>>>>> I'd rather wait another two minutes for the product to download than to
>>>>>>>> have to spend five minutes reading documentation and changing settings 
>>>>>>>> and
>>>>>>>> rebooting AS, with all the things that can go wrong if I mistype some
>>>>>>>> config.
>>>>>>>>
>>>>>>>
>>>>>>> Agreed Paul..
>>>>>>> Can we have something to install a feature at server startup via p2
>>>>>>> level?.
>>>>>>> Another option is to provide different flavors of AS. eg: j2ee
>>>>>>> version, jax-rs/ws version, etc. So users can download what they need.
>>>>>>>
>>>>>>> thanks,
>>>>>>>
>>>>>>>>
>>>>>>>> Paul
>>>>>>>>
>>>>>>>>
>>>>>>>> On 25 June 2013 07:21, Sameera Jayasoma <[email protected]> wrote:
>>>>>>>>
>>>>>>>>> Sagara, Pradeep and myself had a discussion on this. Here are the
>>>>>>>>> notes.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>    - Came up with a P2 based solution to install various runtime
>>>>>>>>>    extensions into AS.
>>>>>>>>>     - Runtimes will be created as P2 features. Required jar files
>>>>>>>>>    will be treated as regular files and will be copied to the
>>>>>>>>>    CARBON_HOME/lib/runtimes directory using default P2 touchpoints.
>>>>>>>>>    - Once a runtime is installed, user will have to update a
>>>>>>>>>    configuration file to include the installed runtime.
>>>>>>>>>    - User guide will be create to explain this process.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Thanks,
>>>>>>>>> Sameera.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> On Fri, Jun 21, 2013 at 7:31 AM, Supun Malinga <[email protected]>wrote:
>>>>>>>>>
>>>>>>>>>> Hi Azeez,
>>>>>>>>>>
>>>>>>>>>> So in the runtime environments scenario, we have some duplication
>>>>>>>>>> between runtime vs the plugins. But the argument in here is that a 
>>>>>>>>>> user
>>>>>>>>>> should be able to use/sxpose the runtime only and get their job done.
>>>>>>>>>> For eg: user has a jax-rs application. So he will expose the cxf
>>>>>>>>>> runtime env. to the app. But he won't expose carbon. So in this case 
>>>>>>>>>> we
>>>>>>>>>> need to have all cxf dependencies too within the cxf runtime env.
>>>>>>>>>>
>>>>>>>>>> thanks,
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> On Fri, Jun 21, 2013 at 7:12 AM, Afkham Azeez <[email protected]>wrote:
>>>>>>>>>>
>>>>>>>>>>> I think the size can be reduced a lot by reviewing & removing
>>>>>>>>>>> duplicated jars  & unnecessary stuff, before we start thinking of P2
>>>>>>>>>>>
>>>>>>>>>>> Azeez
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> On Thu, Jun 20, 2013 at 5:43 PM, Sagara Gunathunga <
>>>>>>>>>>> [email protected]> wrote:
>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Size of the AS distribution becoming very large with last few
>>>>>>>>>>>> releases. AS 4.1.2 is about 160 MB and AS 5.1.0 is around 200 MB 
>>>>>>>>>>>> my current
>>>>>>>>>>>> understanding is AS size will become around 230/240 MB in AS 5.2.0 
>>>>>>>>>>>> release
>>>>>>>>>>>> with JSF, JPA and JTA support, basically once we support for 
>>>>>>>>>>>> J2EE-WP spec
>>>>>>>>>>>> AS end up with extra ~100 MB.
>>>>>>>>>>>>
>>>>>>>>>>>> WSO2 product/features can be installed  to AS through P2 repo
>>>>>>>>>>>> hence it's not an issue here. But still it's not clear whether we 
>>>>>>>>>>>> could use
>>>>>>>>>>>> any P2  based solution to add Classlaoder Environments (CLE) to 
>>>>>>>>>>>> the basic
>>>>>>>>>>>> AS distribution.
>>>>>>>>>>>>
>>>>>>>>>>>> For AS 5.2.0 we have following CLEs addition to basic Carbon
>>>>>>>>>>>> and Tomcat CLEs.
>>>>>>>>>>>>
>>>>>>>>>>>> 1. CXF  ( ~20 to ~25 MB)
>>>>>>>>>>>> 2. J2EE ( ~ 30 MB)
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> It's not possible to use P2 mechanism as it is to install CLEs
>>>>>>>>>>>> because those are not instilled to OSGi runtime instead they stay 
>>>>>>>>>>>> out side
>>>>>>>>>>>> the OSGi runtime. Following are the steps we need to perform to 
>>>>>>>>>>>> add a CLE
>>>>>>>>>>>> to AS.
>>>>>>>>>>>>
>>>>>>>>>>>> 1. Modify and add an entry to the
>>>>>>>>>>>> "webapp-classloading-environments.xml" file located on
>>>>>>>>>>>> "repository/conf/tomcat" directory.
>>>>>>>>>>>>
>>>>>>>>>>>> 2. Copy a directory with set of Jar files into the
>>>>>>>>>>>> "lib/runtimes" directory.
>>>>>>>>>>>>
>>>>>>>>>>>> 3. Copy some samples to the "samples" directory (Optional).
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>> Above tasks can be easily done with small Ant script but it
>>>>>>>>>>>> would be much better to use P2 as it's the platform level 
>>>>>>>>>>>> mechanism to add
>>>>>>>>>>>> new features. Any idea how we could  do this using P2 ?
>>>>>>>>>>>>
>>>>>>>>>>>> Thanks !
>>>>>>>>>>>>
>>>>>>>>>>>> --
>>>>>>>>>>>> Sagara Gunathunga
>>>>>>>>>>>>
>>>>>>>>>>>> Senior Technical Lead; WSO2, Inc.;  http://wso2.com
>>>>>>>>>>>> V.P Apache Web Services;    http://ws.apache.org/
>>>>>>>>>>>> Linkedin; http://www.linkedin.com/in/ssagara
>>>>>>>>>>>> Blog ;  http://ssagara.blogspot.com
>>>>>>>>>>>>
>>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>>
>>>>>>>>>>> --
>>>>>>>>>>> *Afkham Azeez*
>>>>>>>>>>> Director of Architecture; WSO2, Inc.; http://wso2.com
>>>>>>>>>>> Member; Apache Software Foundation; http://www.apache.org/
>>>>>>>>>>> * <http://www.apache.org/>**
>>>>>>>>>>> email: **[email protected]* <[email protected]>* cell: +94 77 3320919
>>>>>>>>>>> blog: **http://blog.afkham.org* <http://blog.afkham.org>*
>>>>>>>>>>> twitter: 
>>>>>>>>>>> **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez>
>>>>>>>>>>> *
>>>>>>>>>>> linked-in: **http://lk.linkedin.com/in/afkhamazeez*
>>>>>>>>>>> *
>>>>>>>>>>> *
>>>>>>>>>>> *Lean . Enterprise . Middleware*
>>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>> --
>>>>>>>>>> Supun Malinga,
>>>>>>>>>>
>>>>>>>>>> Senior Software Engineer,
>>>>>>>>>> WSO2 Inc.
>>>>>>>>>> http://wso2.com
>>>>>>>>>> http://wso2.org
>>>>>>>>>> email - [email protected] <[email protected]>
>>>>>>>>>> mobile - 071 56 91 321
>>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> --
>>>>>>>>> Sameera Jayasoma,
>>>>>>>>> Architect,
>>>>>>>>>
>>>>>>>>> WSO2, Inc. (http://wso2.com)
>>>>>>>>> email: [email protected]
>>>>>>>>> blog: http://sameera.adahas.org
>>>>>>>>> twitter: https://twitter.com/sameerajayasoma
>>>>>>>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>>>>>>>>>
>>>>>>>>>
>>>>>>>>> Lean . Enterprise . Middleware
>>>>>>>>>
>>>>>>>>> _______________________________________________
>>>>>>>>> Architecture mailing list
>>>>>>>>> [email protected]
>>>>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>>>>>>
>>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>> --
>>>>>>>> Paul Fremantle
>>>>>>>> CTO and Co-Founder, WSO2
>>>>>>>> OASIS WS-RX TC Co-chair, VP, Apache Synapse
>>>>>>>>
>>>>>>>> UK: +44 207 096 0336
>>>>>>>> US: +1 646 595 7614
>>>>>>>>
>>>>>>>> blog: http://pzf.fremantle.org
>>>>>>>> twitter.com/pzfreo
>>>>>>>> [email protected]
>>>>>>>>
>>>>>>>> wso2.com Lean Enterprise Middleware
>>>>>>>>
>>>>>>>> Disclaimer: This communication may contain privileged or other
>>>>>>>> confidential information and is intended exclusively for the 
>>>>>>>> addressee/s.
>>>>>>>> If you are not the intended recipient/s, or believe that you may have
>>>>>>>> received this communication in error, please reply to the sender 
>>>>>>>> indicating
>>>>>>>> that fact and delete the copy you received and in addition, you should 
>>>>>>>> not
>>>>>>>> print, copy, retransmit, disseminate, or otherwise use the information
>>>>>>>> contained in this communication. Internet communications cannot be
>>>>>>>> guaranteed to be timely, secure, error or virus-free. The sender does 
>>>>>>>> not
>>>>>>>> accept liability for any errors or omissions.
>>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>> --
>>>>>>> Supun Malinga,
>>>>>>>
>>>>>>> Senior Software Engineer,
>>>>>>> WSO2 Inc.
>>>>>>> http://wso2.com
>>>>>>> http://wso2.org
>>>>>>> email - [email protected] <[email protected]>
>>>>>>> mobile - 071 56 91 321
>>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>> --
>>>>>> Paul Fremantle
>>>>>> CTO and Co-Founder, WSO2
>>>>>> OASIS WS-RX TC Co-chair, VP, Apache Synapse
>>>>>>
>>>>>> UK: +44 207 096 0336
>>>>>> US: +1 646 595 7614
>>>>>>
>>>>>> blog: http://pzf.fremantle.org
>>>>>> twitter.com/pzfreo
>>>>>> [email protected]
>>>>>>
>>>>>> wso2.com Lean Enterprise Middleware
>>>>>>
>>>>>> Disclaimer: This communication may contain privileged or other
>>>>>> confidential information and is intended exclusively for the addressee/s.
>>>>>> If you are not the intended recipient/s, or believe that you may have
>>>>>> received this communication in error, please reply to the sender 
>>>>>> indicating
>>>>>> that fact and delete the copy you received and in addition, you should 
>>>>>> not
>>>>>> print, copy, retransmit, disseminate, or otherwise use the information
>>>>>> contained in this communication. Internet communications cannot be
>>>>>> guaranteed to be timely, secure, error or virus-free. The sender does not
>>>>>> accept liability for any errors or omissions.
>>>>>>
>>>>>> _______________________________________________
>>>>>> Architecture mailing list
>>>>>> [email protected]
>>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>>>
>>>>>>
>>>>>
>>>>>
>>>>> --
>>>>> *Pradeep Fernando*
>>>>> Associate Technical Lead;WSO2 Inc.; http://wso2.com
>>>>>
>>>>> blog: http://pradeepfernando.blogspot.com
>>>>> m: +94776603662
>>>>>
>>>>> _______________________________________________
>>>>> Architecture mailing list
>>>>> [email protected]
>>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> Paul Fremantle
>>>> CTO and Co-Founder, WSO2
>>>> OASIS WS-RX TC Co-chair, VP, Apache Synapse
>>>>
>>>> UK: +44 207 096 0336
>>>> US: +1 646 595 7614
>>>>
>>>> blog: http://pzf.fremantle.org
>>>> twitter.com/pzfreo
>>>> [email protected]
>>>>
>>>> wso2.com Lean Enterprise Middleware
>>>>
>>>> Disclaimer: This communication may contain privileged or other
>>>> confidential information and is intended exclusively for the addressee/s.
>>>> If you are not the intended recipient/s, or believe that you may have
>>>> received this communication in error, please reply to the sender indicating
>>>> that fact and delete the copy you received and in addition, you should not
>>>> print, copy, retransmit, disseminate, or otherwise use the information
>>>> contained in this communication. Internet communications cannot be
>>>> guaranteed to be timely, secure, error or virus-free. The sender does not
>>>> accept liability for any errors or omissions.
>>>>
>>>> _______________________________________________
>>>> Architecture mailing list
>>>> [email protected]
>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>>
>>>>
>>>
>>>
>>> --
>>> Sameera Jayasoma,
>>> Architect,
>>>
>>> WSO2, Inc. (http://wso2.com)
>>> email: [email protected]
>>> blog: http://sameera.adahas.org
>>> twitter: https://twitter.com/sameerajayasoma
>>> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>>>
>>> Lean . Enterprise . Middleware
>>>
>>> _______________________________________________
>>> Architecture mailing list
>>> [email protected]
>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>
>>>
>>
>>
>> --
>> *Software Engineer - WSO2 Inc.*
>> *email: shameera AT wso2.com <[email protected]> , shameera AT 
>> apache.org<[email protected]>
>> *
>> *phone:  +9471 922 1454*
>> *
>> *
>> *Linked in : *http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561
>> *Twitter     : *https://twitter.com/Shameera_R
>>
>> _______________________________________________
>> Architecture mailing list
>> [email protected]
>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>
>>
>
>
> --
> Sameera Jayasoma,
> Architect,
>
> WSO2, Inc. (http://wso2.com)
> email: [email protected]
> blog: http://sameera.adahas.org
> twitter: https://twitter.com/sameerajayasoma
> flickr: http://www.flickr.com/photos/sameera-jayasoma/collections
>
> Lean . Enterprise . Middleware
>
> _______________________________________________
> Architecture mailing list
> [email protected]
> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>
>


-- 
*Software Engineer - WSO2 Inc.*
*email: shameera AT wso2.com <[email protected]> , shameera AT
apache.org<[email protected]>
*
*phone:  +9471 922 1454*
*
*
*Linked in : *http://lk.linkedin.com/pub/shameera-rathnayaka/1a/661/561
*Twitter     : *https://twitter.com/Shameera_R
_______________________________________________
Architecture mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture

Reply via email to