A few comments on the operation names: - All operation names should start with a lowercase letter. Some of them, like ListComments and ListProperty and a few others, start with upper case. Please fix. - listFile should be listFiles - listFilePermission should be listFilePermissions - Does "child" refer to both files and folders? If so, child is fine, but if we're talking specifically about files or folders, we should use the correct term explicitly in the name. For example, does getChild really make sense? Shouldn't it be getFolder? Are we passing in the folder's name/key or an index (e.g., do you pass in 1 to get the first child folder?) If it's by name/key, it should be getFolder. If it's by index, it should be getChildFolder. - We have both delete and DeleteChild in your list. There should be only one, deleteChild (note that it starts with lower case). As per the previous point, if we're passing in a name/key to this operation, this should be deleteFile if it only refers to files or deleteFolder if it only refers to folders, but if you're passing in an index, then it should be deleteChildFile or deleteChildFolder. - Likewise, we have both getChild and GetChildRef, which appear to do the same thing. Should be one operation, getChild (or getFolder, if that's what this is doing). - ListProperty should be listProperties (lower case and plural) - In some insert operations, we include "new" and in others we don't. I'd say we don't need it, so just insertProperty and insertReply should be fine.
Thanks, Jackie On Tue, Dec 10, 2013 at 10:45 PM, Chanaka Fernando <[email protected]>wrote: > Hi Indika, > > Since Google Drive is somewhat related to files, it is better to have some > folder related methods to your supported list. My suggestion is to add the > following methods to your list of supporting methods. > > • *touchFile *Set the file's updated time to > the current server time. > • *getChild *Gets a specific child reference. > > • *insertFiletoFolder *Inserts a file into a > folder. > • *listFolders *Lists a folder's children. To > list all children of the > root folder, use the alias root for the folderId value. > > WDYT? > > Thanks, > Chanaka > > > On Tue, Dec 10, 2013 at 10:24 AM, indika prasad <[email protected]>wrote: > >> *Introduction* >> >> Google Drive is a file storage and synchronization service provided by >> Google, which enables user cloud storage, file sharing and collaborative >> editing. >> Google Drive API is used to deal with google drive to perform certain >> operations allowed by the API. >> >> Google Drive Connector Summery >> >> • Connector Name: GoogleDrive >> • Version: 1.00 >> • Technology: Java >> >> *Authentication*: >> >> There are two types of accounts that can be owned by any application. >> Service accounts or regular Google accounts. Service accounts associated >> with a service or a project. They do not belong to a user and can only be >> accessed programmatically by the associated application. Regular account >> is >> belong to the user. GoogleDrive connector is support for both type of >> accounts and authentication flow is depending on account type as bellow. >> >> • Service account authentication: >> End user need to provide service account email address and private >> key to authenticate. >> • Regular account authentication: >> Client id, Client Secrete, access token and refresh token are >> needed >> to authenticate. >> >> *Methods Summery* >> Selected Methods (17) for version 1.0 >> • *init* Config data for the connector. >> • *getFile *Gets a file's metadata by ID. >> • *insertFile* Insert a new file. >> • *patchFile *Updates file metadata. This >> method supports patch semantics. >> • *updateFile *Updates file metadata and/or >> content. >> • *copyFile *Creates a copy of the specified >> file. >> • *deleteFile *Permanently deletes a file by >> ID. Skips the trash. >> • *ListFile *Lists the user's files. >> • *trashFile *Moves a file to the trash. >> • *untrashFile *Restores a file from the trash. >> • *watchFile *Start watching for changes to a >> file. >> • *listChangesForUser *Lists the changes for a >> user. >> • *insertPermissionToFile *Inserts permission for a >> file. >> • *listFilePermission *Lists a file's >> permissions. >> • *deleteComment *Deletes a comment. >> • *getCommentByID *Gets a comment by ID. >> • *insertNewComment *Creates a new comment on >> the given file. >> >> >> >> Rest of the available methods(23) provided by the API >> • *touchFile *Set the file's updated time to >> the current server time. >> • *delete *Removes a child from a folder. >> • *getChild *Gets a specific child reference. >> • *insertFiletoFolder *Inserts a file into a >> folder. >> • *listFolders *Lists a folder's children. To >> list all children of the >> root folder, use the alias root for the folderId value. >> • *deleteParentFromFile *Removes a parent from a >> file. >> • *getParentReference *Gets a specific parent >> reference. >> • *insertParentFolderToFile * Adds a parent >> folder for a file. >> • *listParents *Lists a file's parents. >> • *deletePermissionFromFile *Deletes >> permission from a file. >> • *getPermissionID *Gets permission by ID. >> • *getIdForEmail *Returns the permission ID for an >> email address. >> • *ListComments *Lists a file's comments. >> • *deleteReply *Deletes a reply. >> • *getReply *Gets a reply. >> • *insertNewReply *Creates a new reply to the given >> comment. >> • *ListReplies *Lists all of the replies to a >> comment. >> • *deleteProperty *Deletes a property. >> • *getProperty *Gets a property by its key. >> • *insertNewProperty *Adds a property to a >> file. >> • *ListProperty *Lists a file's properties. >> • *DeleteChild *Removes a child from a folder. >> • *GetChildRef *Gets a specific child reference. >> >> Your comments are greatly appreciate. >> >> Thanks >> Indika Kularathne >> >> >> >> >> -- >> View this message in context: >> http://wso2-oxygen-tank.10903.n7.nabble.com/Connector-Google-Drive-tp89555.html >> Sent from the WSO2 Architecture mailing list archive at Nabble.com. >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> > > > > -- > -- > Chanaka Fernando > Technical Lead > WSO2, Inc.; http://wso2.com > lean.enterprise.middleware > > mobile: +94 773337238 > Blog : http://soatutorials.blogspot.com > LinkedIn:http://www.linkedin.com/pub/chanaka-fernando/19/a20/5b0 > Twitter:https://twitter.com/chanakaudaya > Wordpress:http://chanakaudaya.wordpress.com > > > > > _______________________________________________ > Architecture mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > > -- *Jackie Wheeler* VP, Technical Content WSO2, Inc. Mobile: +1 510 725-2876 http://wso2.com/
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
