Hi Johann,
On Thu, Dec 19, 2013 at 8:22 PM, Venura Kahawala <[email protected]> wrote: > Hi Johann, > > Yes you are correct for the general case, but in our API we have defined > the EntityIdentifier with a constructor having string parameter, > therefore default constructor is not valid. In these case it is not valid > to have a constructor with a string parameter for the static class IMO. > > Here what I mentioned is this is possible, but a bad pattern. Added this comment since "valid word" might be misleading. > Regards, > Venura > > > On Thu, Dec 19, 2013 at 8:06 PM, Johann Nallathamby <[email protected]>wrote: > >> Hi Prabath, >> >> On Thu, Dec 19, 2013 at 7:56 PM, Prabath Siriwardena <[email protected]>wrote: >> >>> A nested class should exist only to serve its enclosing class... if the >>> purpose of it goes beyond that - then it should be a top level one. For >>> that reason, I did't want to have Identifier classes as nested classes... >>> >> >> I was only thinking about the readability aspect and packaging aspect. >> Otherwise there is no real reason for it. That's why I suggested static >> nested classes rather than non-static inner classes since they need to have >> existence without the existence of their enclosing class. >> >> May be I am wrong here. >> >> >>> Thanks & regards, >>> -Prabath >>> >>> >>> On Thu, Dec 19, 2013 at 6:07 PM, Johann Nallathamby <[email protected]>wrote: >>> >>>> Hi Prabath, >>>> >>>> One more suggestion I wanted to tell and missed is, what if we have the >>>> Identifier classes of each entity as a static nested class of the >>>> corresponding entity? This way it will make the packaging more neat. >>>> >>>> >>>> On Thu, Dec 19, 2013 at 1:26 PM, Prabath Siriwardena >>>> <[email protected]>wrote: >>>> >>>>> Participants : Azeez, Srinath, Sameera,SameeraP Manoj, >>>>> Kishanthan,Johann, Venura, Ishara, Chamath, Darshana, Pradeep, Prabath >>>>> >>>>> - Overall we agreed on the design. >>>>> - Separate out IdentityService API in to tow top level APIs - one for >>>>> store administration and another for user/group/role/permission >>>>> administration >>>>> - Authenticated user should be independent from the Authorization Store >>>>> - JAAS implementation >>>>> >>>>> Next steps : >>>>> >>>>> - Commit the API code to Git >>>>> - File based implementation for C5 >>>>> - Validate the API with further implementations with LDAP/AD >>>>> - Documentation >>>>> >>>>> Will schedule another review in January. >>>>> >>>>> Thanks a lot everyone for your time..! >>>>> >>>>> Thanks & regards, >>>>> -Prabath >>>>> >>>>> >>>>> On Tue, Dec 17, 2013 at 3:15 PM, Johann Nallathamby >>>>> <[email protected]>wrote: >>>>> >>>>>> more details >>>>>> »<https://www.google.com/calendar/event?action=VIEW&eid=bTh1ZmxrY2p0YmlhaDcwZm51MDJvYnJoaWsgcHJhYmF0aEB3c28yLmNvbQ&tok=MTUjam9oYW5uQHdzbzIuY29tZjI0MmRkYzUxYWI1ZGViMWRlZDU4ZjdkZWZiNzkzODdiNzNmMWQ4Nw&ctz=Asia/Colombo&hl=en> >>>>>> Carbon 5 User API Design Review >>>>>> Carbon 5 User Core API Design - Public Review >>>>>> *When* >>>>>> Thu Dec 19, 2013 11am – 12pm Colombo >>>>>> *Where* >>>>>> LK 5th Floor Meeting Room - Garage >>>>>> (map<http://maps.google.lk/maps?q=LK+5th+Floor+Meeting+Room+-+Garage&hl=en> >>>>>> ) >>>>>> *Calendar* >>>>>> [email protected] >>>>>> *Who* >>>>>> • >>>>>> Johann Nallathamby - organizer >>>>>> • >>>>>> Chamath Gunawardana >>>>>> • >>>>>> [email protected] >>>>>> • >>>>>> Paul Fremantle >>>>>> • >>>>>> Dimuthu Leelarathne >>>>>> • >>>>>> Darshana Gunawardana >>>>>> • >>>>>> Sameera Jayasoma >>>>>> • >>>>>> Asela Pathberiya >>>>>> • >>>>>> Prabath Siriwardana >>>>>> • >>>>>> Srinath Perera >>>>>> • >>>>>> Afkham Azeez >>>>>> • >>>>>> Sanjiva Weerawarana >>>>>> • >>>>>> Dulanja Liyanage >>>>>> • >>>>>> Sumedha Rubasinghe >>>>>> • >>>>>> Ishara Karunarathna >>>>>> *Attachments* >>>>>> >>>>>> c5-user-core-api-highlevel-design.png<https://lh6.googleusercontent.com/DiBqCFm-4bjETgEgayV1xMMJ9zxe-NWrMl2MLEzcBhjGjCf3foc2nDDo8dcHorwC9MdBBBREPSmKrtxsbP-FDMo=s400> >>>>>> >>>>>> Going? *Yes >>>>>> <https://www.google.com/calendar/event?action=RESPOND&eid=bTh1ZmxrY2p0YmlhaDcwZm51MDJvYnJoaWsgcHJhYmF0aEB3c28yLmNvbQ&rst=1&tok=MTUjam9oYW5uQHdzbzIuY29tZjI0MmRkYzUxYWI1ZGViMWRlZDU4ZjdkZWZiNzkzODdiNzNmMWQ4Nw&ctz=Asia/Colombo&hl=en> >>>>>> - Maybe >>>>>> <https://www.google.com/calendar/event?action=RESPOND&eid=bTh1ZmxrY2p0YmlhaDcwZm51MDJvYnJoaWsgcHJhYmF0aEB3c28yLmNvbQ&rst=3&tok=MTUjam9oYW5uQHdzbzIuY29tZjI0MmRkYzUxYWI1ZGViMWRlZDU4ZjdkZWZiNzkzODdiNzNmMWQ4Nw&ctz=Asia/Colombo&hl=en> >>>>>> - No >>>>>> <https://www.google.com/calendar/event?action=RESPOND&eid=bTh1ZmxrY2p0YmlhaDcwZm51MDJvYnJoaWsgcHJhYmF0aEB3c28yLmNvbQ&rst=2&tok=MTUjam9oYW5uQHdzbzIuY29tZjI0MmRkYzUxYWI1ZGViMWRlZDU4ZjdkZWZiNzkzODdiNzNmMWQ4Nw&ctz=Asia/Colombo&hl=en>* >>>>>> more options >>>>>> »<https://www.google.com/calendar/event?action=VIEW&eid=bTh1ZmxrY2p0YmlhaDcwZm51MDJvYnJoaWsgcHJhYmF0aEB3c28yLmNvbQ&tok=MTUjam9oYW5uQHdzbzIuY29tZjI0MmRkYzUxYWI1ZGViMWRlZDU4ZjdkZWZiNzkzODdiNzNmMWQ4Nw&ctz=Asia/Colombo&hl=en> >>>>>> >>>>>> Invitation from Google Calendar <https://www.google.com/calendar/> >>>>>> >>>>>> You are receiving this email at the account [email protected] because >>>>>> you are subscribed for invitations on calendar [email protected]. >>>>>> >>>>>> To stop receiving these notifications, please log in to >>>>>> https://www.google.com/calendar/ and change your notification >>>>>> settings for this calendar. >>>>>> >>>>> >>>>> >>>>> >>>>> -- >>>>> Thanks & Regards, >>>>> Prabath >>>>> >>>>> Twitter : @prabath >>>>> LinkedIn : http://www.linkedin.com/in/prabathsiriwardena >>>>> >>>>> Mobile : +94 71 809 6732 >>>>> >>>>> http://blog.facilelogin.com >>>>> http://blog.api-security.org >>>>> >>>> >>>> >>>> >>>> -- >>>> Thanks & Regards, >>>> >>>> *Johann Dilantha Nallathamby* >>>> Senior Software Engineer >>>> Integration Technologies Team >>>> WSO2, Inc. >>>> lean.enterprise.middleware >>>> >>>> Mobile - *+94777776950* >>>> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >>>> >>> >>> >>> >>> -- >>> Thanks & Regards, >>> Prabath >>> >>> Twitter : @prabath >>> LinkedIn : http://www.linkedin.com/in/prabathsiriwardena >>> >>> Mobile : +94 71 809 6732 >>> >>> http://blog.facilelogin.com >>> http://blog.api-security.org >>> >> >> >> >> -- >> Thanks & Regards, >> >> *Johann Dilantha Nallathamby* >> Senior Software Engineer >> Integration Technologies Team >> WSO2, Inc. >> lean.enterprise.middleware >> >> Mobile - *+94777776950* >> Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>* >> >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > Senior Software Engineer > > Mobile: +94 71 82 300 20 > > Regards, Venura -- Senior Software Engineer Mobile: +94 71 82 300 20
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
