IMO, the UI framework/Jetty integration should be outside the kernel. Azeez
On Tue, Mar 11, 2014 at 12:52 PM, Kishanthan Thangarajah < [email protected]> wrote: > > > > On Tue, Mar 11, 2014 at 12:04 AM, Sagara Gunathunga <[email protected]>wrote: > >> >> >> >> On Mon, Mar 10, 2014 at 10:11 PM, Kishanthan Thangarajah < >> [email protected]> wrote: >> >>> We have done $subject which can be used for servlet transport in C5 >>> kernel [1]. The embedded jetty instance uses a default jetty.xml >>> configuration file located at >>> $CARBON_HOME/repository/conf/jetty/jetty.xml. The main advantage of >>> jetty is that it is OSGi friendly [2]. It can also expose the OSGi >>> HttpSevice for servlet registrations, etc. >>> >>> We are thinking of using this for the UI framework of carbon. Other >>> servlet container can also be plugged in (Eg: Tomcat with AS) using the >>> plugable run-time concept, but they will use different ports to avoid >>> >> >> +1 please see my comments below. >> >> 1.) Have we define the scope of Jetty integration within Carbon ? if not >> we need to define what are the supported Jetty features and what are the >> features not supported based on our needs. To make it clear we are not >> trying to make Tomcat kind of integration here instead we need basic >> servlet support for Admine console, we don't need to support web socket , >> JSP 2.2 , EL 2.2 etc :) But if we don't define the scope users may >> confuse and can be treated as a weakness and there is a high chance to >> compare Carbon-Jetty with Carbon-Tomcat. >> > > The current plan is to use this for UI framework, and AdminServices > framework (JAX-RS services, which we need the servlet support). We don't > need to support all the features of jetty at kernel level. The main purpose > of this to remove the dependency of tomcat at kernel level. So that > products like AS can independently do changes (like upgrading tomcat). > Integration and usage of Tomcat will be same like before (like Apps hosting > in AS), but the only change is that UI and AdminServices framework will use > Jetty instead. > > >> 2.) What are the dependencies required for Jetty and how we going to >> keep them ? within the Jetty bundle or import from other bundles ? If >> 2nd one is the approach we need to be very careful and should follow best >> practises like OSGi versioning etc from day-0. I would prefer if Carbon >> not exporting dependencies like servlet-api , xml-api etc so that each >> Carbon product can have control on these dependencies. >> > > We could solve these type of issues with proper package imports/exports > with versions. > > >> >> 3.) It would be better to avoid publishing Jeety related details on user >> guides, here Jetty is the underline framework we used but what Carbon user >> wants is technology to right admin UIs and admin services that's what we >> need to cover on user guides. One good example is Jetty support on GAE. >> > > +1. > >> >> >> Thanks ! >> >> >>> collisions. >>> >>> Thanks, >>> Kishanthan. >>> [1] https://wso2.org/jira/browse/CARBON-14716 >>> [2] http://wiki.eclipse.org/Jetty/Feature/Jetty_OSGi >>> >>> -- >>> *Kishanthan Thangarajah* >>> Senior Software Engineer, >>> Platform Technologies Team, >>> WSO2, Inc. >>> lean.enterprise.middleware >>> >>> Mobile - +94773426635 >>> Blog - *http://kishanthan.wordpress.com >>> <http://kishanthan.wordpress.com>* >>> Twitter - *http://twitter.com/kishanthan >>> <http://twitter.com/kishanthan>* >>> >>> _______________________________________________ >>> Architecture mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >>> >> >> >> -- >> Sagara Gunathunga >> >> Senior Technical Lead; WSO2, Inc.; http://wso2.com >> V.P Apache Web Services; http://ws.apache.org/ >> Linkedin; http://www.linkedin.com/in/ssagara >> Blog ; http://ssagara.blogspot.com >> >> >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > *Kishanthan Thangarajah* > Senior Software Engineer, > Platform Technologies Team, > WSO2, Inc. > lean.enterprise.middleware > > Mobile - +94773426635 > Blog - *http://kishanthan.wordpress.com <http://kishanthan.wordpress.com>* > Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>* > > _______________________________________________ > Architecture mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > > -- *Afkham Azeez* Director of Architecture; WSO2, Inc.; http://wso2.com Member; Apache Software Foundation; http://www.apache.org/ * <http://www.apache.org/>* *email: **[email protected]* <[email protected]> * cell: +94 77 3320919 blog: **http://blog.afkham.org*<http://blog.afkham.org> *twitter: **http://twitter.com/afkham_azeez*<http://twitter.com/afkham_azeez> * linked-in: **http://lk.linkedin.com/in/afkhamazeez <http://lk.linkedin.com/in/afkhamazeez>* *Lean . Enterprise . Middleware*
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
