On Sun, Apr 20, 2014 at 2:29 PM, Dimuthu Leelarathne <[email protected]>wrote:
> Hi Sumedha, > > Please see my comments inline. > > On Sun, Apr 20, 2014 at 9:04 AM, Sumedha Kodithuwakku > <[email protected]>wrote: > >> Hi all, >> >> In the new cloud user model we have two attributes (Company Display Name >> and Company ID) related to the organization which can be set by the user >> when adding the organization. The company ID maps to the tenant domain in a >> tenant. >> >> There is a suggestion to remove the '.ext' part from the Company ID and >> make it just a unique character sequence (i.e remove '*.com*' from '*abc.com >> <http://abc.com>*' and just use '*abc*'). However since tenant domain >> must be having a '.ext' this is not possible currently. >> >> AFAIU there are two possible solutions for this; >> >> 1. Use the tenant domain as it is in the back end and do the removal >> of the '.ext' in the front end. IMHO this is more error prone and will be >> difficult to maintain and will require lot of changes in the front end >> too. >> 2. Remove the validation done for the '.ext' when creating the >> tenant. AFAIK the validation for the '.ext' in tenant domain only happens >> when the tenant is being created. After that we will take the tenant >> domain as what ever behind the '@' symbol of a user name and use it. IMHO >> this is much cleaner and easy to maintain than the first approach. >> However >> we will have to modify the tenant.mgt component [1] to do this (or extend >> it). >> >> > You are correct in saying that at the platform level it is just a string > and validation is only in the UI. The consistency of the platform won't be > damaged at the platform if you remove it. (Even this validation was added > much later and depends on a property in a config file) > AFAIK there is no config for tenant domain validation. It seems to be hardcoded in the BE service. So, we'll have to fix that one too. Dimuthu, do you know of such a config? > > +1 for removing the validation. > > thanks, > dimuthu > > >> >> >> Suggestions/ thoughts are welcome..! >> >> [1] >> https://svn.wso2.org/repos/wso2/carbon/platform/branches/turing/components/stratos/tenant-mgt/org.wso2.carbon.tenant.mgt/ >> >> Thanks >> SumedhaS >> -- >> *Sumedha Kodithuwakku* >> Software Engineer >> WSO2 Inc. : wso2.com >> lean . enterprise . middleware >> >> Email: [email protected]; Mobile: +94 71 808 1124 >> Blog: http://sumedhask.blogspot.com/ >> >> > > > -- > Dimuthu Leelarathne > Architect & Product Lead of App Factory > > WSO2, Inc. (http://wso2.com) > email: [email protected] > Mobile : 0773661935 > > Lean . Enterprise . Middleware > -- *Amila Maharachchi* Senior Technical Lead WSO2, Inc.; http://wso2.com Blog: http://maharachchi.blogspot.com Mobile: +94719371446
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
