Hi Danushka, +1. I don't see any harm in making it extensible.
thanks, dimuthu On Tue, May 6, 2014 at 2:12 PM, Danushka Fernando <[email protected]>wrote: > Any Ideas on this? > > Thanks & Regards > Danushka Fernando > Software Engineer > WSO2 inc. http://wso2.com/ > Mobile : +94716332729 > > > On Fri, May 2, 2014 at 4:02 PM, Danushka Fernando <[email protected]>wrote: > >> Hi all >> In user management area we have made lot of stuff extensible. We can >> write our own user store managers, tenant managers and authorization >> managers. So most of the time when we write a custom one we extend form an >> existing one. >> >> For example We implement >> tenant managers extended from JDBCTenantManager >> user store managers extended from ReadOnlyLDAPUserStoreManager / >> ReadWriteLDAPUserStoreManager. >> >> Because what we want to customize might not be the whole class. It could >> be a one operation of the class. >> >> Like that the implementation of Authorization Manager we can extend from >> is JDBCAuthorizationManager. But current implementation >> of JDBCAuthorizationManager is not extensible due to following reasons. >> >> >> 1. All the object level variables are private not protected. >> 2. Lot of methods of the class are private. >> 3. SearchResult class is visible only to the particular package. >> >> >> If we make all necessary private things protected, then some one can >> extend it and write his/her own Authorization Manager. Can we >> update JDBCAuthorizationManager code to make it extensible. >> >> Thanks & Regards >> Danushka Fernando >> Software Engineer >> WSO2 inc. http://wso2.com/ >> Mobile : +94716332729 >> > > -- Dimuthu Leelarathne Architect & Product Lead of App Factory WSO2, Inc. (http://wso2.com) email: [email protected] Mobile : 0773661935 Lean . Enterprise . Middleware
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
