Thanks Dakshika for pointing this out On Thu, Oct 23, 2014 at 9:19 AM, Dakshika Jayathilaka <[email protected]> wrote:
> AFAIK your approach is not good. Font Awesome is third party library > that we are using. Also we are not tracking or maintaining any fork on it. > If you change CSS, other users may get confused whether its a older version > or new one. Recommended way is to change our code base instead of changing > code on third party library. > > Regards, > > *Dakshika Jayathilaka* > Software Engineer > WSO2, Inc. > lean.enterprise.middleware > 0771100911 > > On Thu, Oct 23, 2014 at 8:31 AM, Amalka Subasinghe <[email protected]> > wrote: > >> Thanks Dakshika, >> >> Here, I changed the fa-* part to icon-* in .css file. So I could do this >> with minimum changes without changing the usage of icons in *.jag files >> >> Thanks >> Amalka >> >> >> On Thu, Oct 23, 2014 at 6:27 AM, Dakshika Jayathilaka <[email protected]> >> wrote: >> >>> Hi, >>> >>> If you follow the patterns that changes on 4.2.0, you can do your >>> migration work with less effort. >>> >>> Main class is change to icon-* -> fa fa-*. >>> >>> check this migration guide provided by font awesome >>> https://github.com/FortAwesome/Font-Awesome/wiki/Upgrading-from-3.2.1-to-4 >>> for >>> additional class changes. >>> >>> Thank you, >>> >>> *Dakshika Jayathilaka* >>> Software Engineer >>> WSO2, Inc. >>> lean.enterprise.middleware >>> 0771100911 >>> >>> On Wed, Oct 22, 2014 at 4:06 PM, Amalka Subasinghe <[email protected]> >>> wrote: >>> >>>> >>>> Hi, >>>> >>>> Currently App Factory uses Font Awesome 3.2.1 old version. Need to >>>> upgrade to 4.2.0 [1] which is the latest version to get new icons to the >>>> App Factory. >>>> >>>> [1] http://fortawesome.github.io/Font-Awesome/ >>>> [2] https://wso2.org/jira/browse/APPFAC-2592 >>>> >>>> Thanks >>>> Amalka >>>> >>>> >>>> _______________________________________________ >>>> Architecture mailing list >>>> [email protected] >>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>> >>>> >>> >> >> >> -- >> >> Amalka Subasinghe >> >> WSO2 Inc. >> Mobile: +94 77 9401267 >> > > -- Amalka Subasinghe WSO2 Inc. Mobile: +94 77 9401267
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
