Hi Danushka, It is currently implemented in the AppVersionStrategyExecutor class. IMHO I am reluctant to do the refactoring at the moment since we have only two apptypes which follows the single tenant concept. There may be some application types we introduce in the future which are single tenant but may have different implementations as to how the application type is processed.
For the record I have changed the current method doVersionForPHP method to doVersionForGenericApplication and used it in both application processors. I have not committed the code yet. So I would appreciate suggestions for the proper naming for the above method if the current naming is not proper. Regards GayanD On Fri, Oct 31, 2014 at 11:16 AM, Danushka Fernando <[email protected]> wrote: > Hi Gayan > Where this versioning concept is implemented? If it is in ApplicationType > Processor may be we can merge .NET and PHP application type processors and > create an application type processor named something like > SingleTenantApplicationTypeProcessor. WDYT? > > Thanks & Regards > Danushka Fernando > Software Engineer > WSO2 inc. http://wso2.com/ > Mobile : +94716332729 > > On Fri, Oct 31, 2014 at 10:25 AM, Gayan Dhanushka <[email protected]> wrote: > >> Hi all, >> >> According to the current implementation in .NET applications versioning >> is done through the pom file generated with the .NET application archetype. >> This is not ideal since pom file is essentially used for artifact >> versioning and the concept is different from application versioning. The >> fact that we only use the maven archetype to build the .NET application >> also reiterate the need for proper versioning in .NET applications. >> >> As a solution I have done a fix to create a copy of the source version >> and rename it according to the format "<APP_NAME>-<APP_VERSION>-default" >> when creating a new version of a .NET application. This coincide with the >> way that we version PHP applications as well. >> >> Please share your thoughts on this. >> >> Regards >> GayanD >> >> -- >> Gayan Dhanuska >> Software Engineer >> http://wso2.com/ >> Lean Enterprise Middleware >> >> Mobile >> 071 666 2327 >> >> Office >> Tel : 94 11 214 5345 >> Fax : 94 11 214 5300 >> >> Twitter : https://twitter.com/gayanlggd >> > > -- Gayan Dhanuska Software Engineer http://wso2.com/ Lean Enterprise Middleware Mobile 071 666 2327 Office Tel : 94 11 214 5345 Fax : 94 11 214 5300 Twitter : https://twitter.com/gayanlggd
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
