Hi Dimuthu,
+1 for the suggestion.
we were thinking the same way. but the issue here is to get the modified
artifact name list from the jgit api. There is no direct way of getting
modified artifacts since, we keep all the version of the application
artifacts as folders in the same master branch of s2 git repo. I mentioned
the proposed approach in previous mail. your comment on that would be
appreciated.
Thanks,
Roshan Deniyage
Associate Technical Lead
WSO2, Inc: http://wso2.com
Mobile : +94 777636406
Twitter : *https://twitter.com/roshku <https://twitter.com/roshku>*
LinkedIn : https://www.linkedin.com/in/roshandeniyage
On Tue, Nov 4, 2014 at 3:40 AM, Dimuthu Leelarathne <[email protected]>
wrote:
> Hi Roshan,
>
> I've been thinking about this a lot. I think we need to take a different
> approach. Since the message is published by Stratos it must not be AF
> specific. So i believe the ArtifactDeploymentCompletedEvent should have
> the following,
>
> Cartridge Alias +
>
> For each modified artefact it should carry,
>
> 1 - modified artefact name
> 2 - time of modification
> 3 - original Git URL
>
> We have to repeat 1,2,3 for each artefact. I am suggesting this because,
> the event belongs to Stratos and Stratos gives all information, and from AF
> side we listen to the event and do the required calculation and update our
> databases.
>
> Additional advantage is that, this allows us to reuse the versioning rules
> (which are mostly based on artefact name) that we have inplace for AF.
>
> WDYT?
>
> thanks,
> dmuthu
>
>
>
> On Mon, Nov 3, 2014 at 3:08 AM, Harsha Thirimanna <[email protected]>
> wrote:
>
>>
>> After doing JGit checkout, you will get CheckoutResult and there is a
>> modified list.
>>
>>
>>
>>
>>
>> *Harsha Thirimanna*
>> Senior Software Engineer; WSO2, Inc.; http://wso2.com
>> * <http://www.apache.org/>*
>> *email: **[email protected]* <[email protected]>* cell: +94 71 5186770 ,
>> +94 *
>> *774617784twitter: **http://twitter.com/
>> <http://twitter.com/afkham_azeez>*
>> *harshathirimannlinked-in: **http:
>> <http://lk.linkedin.com/in/afkhamazeez>**//www.linkedin.com/pub/harsha-thirimanna/10/ab8/122
>> <http://www.linkedin.com/pub/harsha-thirimanna/10/ab8/122>*
>>
>> *Lean . Enterprise . Middleware*
>>
>>
>> On Mon, Nov 3, 2014 at 11:29 AM, Imesh Gunaratne <[email protected]> wrote:
>>
>>> Hi Roshan,
>>>
>>> On Fri, Oct 31, 2014 at 6:20 PM, Roshan Deniyage <[email protected]>
>>> wrote:
>>>
>>>> Hi Devs,
>>>> Based on the previous discussion and decision, I'm in the process
>>>> of developing the improvement of the subject as follows,
>>>>
>>>> (1) Publish a new Event called "ArtifactDeploymentCompletedEvent" to
>>>> the "instance-notifier" topic of activemq of stratos side by each cartridge
>>>> agent upon successful git pull.
>>>>
>>>
>>> +1 for proposing this event, we should be able to get the list of
>>> artifacts checked out from git and send it in the event.
>>>
>>> _______________________________________________
>>> Architecture mailing list
>>> [email protected]
>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>>
>>>
>>
>> _______________________________________________
>> Architecture mailing list
>> [email protected]
>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>>
>>
>
>
> --
> Dimuthu Leelarathne
> Architect & Product Lead of App Factory
>
> WSO2, Inc. (http://wso2.com)
> email: [email protected]
> Mobile : 0773661935
>
> Lean . Enterprise . Middleware
>
_______________________________________________
Architecture mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
