On Mon, Nov 17, 2014 at 10:06 AM, Afkham Azeez <[email protected]> wrote:
> > On Mon, Nov 17, 2014 at 8:53 AM, Pubudu Dissanayake <[email protected]> > wrote: > >> >> CarbonTomcatSessionManager > > > What if you simply improve CarbonTomcatSessionManager to support > persistence as well, rather than writing a new class? If you want to turn > off persistence, you can have a parameter. > > CarbonTomcatSessionManager [1] <http://svn.wso2.org/repos/wso2/carbon/platform/branches/turing/components/webapp-mgt/org.wso2.carbon.webapp.mgt/4.2.2/src/main/java/org/wso2/carbon/webapp/mgt/CarbonTomcatSessionManager.java>doesn't support persistence features provided by tomcat, it extends StandardManager [2] <http://grepcode.com/file/repo1.maven.org/maven2/org.apache.tomcat/tomcat-catalina/7.0.0/org/apache/catalina/session/StandardManager.java?av=f> as its base class. However PersistentManager [3] <http://grepcode.com/file/repo1.maven.org/maven2/org.apache.tomcat/tomcat-catalina/7.0.0/org/apache/catalina/session/PersistentManager.java> extends PersistentManagerBase [4] <http://grepcode.com/file/repo1.maven.org/maven2/org.apache.tomcat/tomcat-catalina/7.0.0/org/apache/catalina/session/PersistentManagerBase.java> as its base class thus it contains all persistence related store configurations. Because StandardManager and PersistentManager are two different implementations, we can't use CarbonTomcatSessionManager to support persistence. And we can configure persistence easily by separating these two implementations. WDYT? [1] http://svn.wso2.org/repos/wso2/carbon/platform/branches/turing/components/webapp-mgt/org.wso2.carbon.webapp.mgt/4.2.2/src/main/java/org/wso2/carbon/webapp/mgt/CarbonTomcatSessionManager.java [2] http://grepcode.com/file/repo1.maven.org/maven2/org.apache.tomcat/tomcat-catalina/7.0.0/org/apache/catalina/session/StandardManager.java?av=f [3] http://grepcode.com/file/repo1.maven.org/maven2/org.apache.tomcat/tomcat-catalina/7.0.0/org/apache/catalina/session/PersistentManager.java [4] http://grepcode.com/file/repo1.maven.org/maven2/org.apache.tomcat/tomcat-catalina/7.0.0/org/apache/catalina/session/PersistentManagerBase.java > > > -- *Pubudu Dissanayake* Software Engineer WSO2 Inc.; http://wso2.com lean.enterprise.middleware Mob: + 94 775 503 304 Blog: http://geekdetected.wordpress.com/ Linkedin: *http://lk.linkedin.com/in/pubududissanayake* <http://lk.linkedin.com/in/pubududissanayake> Flickr : https://www.flickr.com/photos/pubudufx/ Twitter: https://twitter.com/GeekInAction
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
