On Fri, Nov 28, 2014 at 11:33 AM, Isuru Perera <[email protected]> wrote:
> Hi, > > +1 for making CipherTool a standalone tool. Rather than using system > properties, let's use a configuration file specific to the tool. > Yes, since this was implemented as a patch, we have to go with System properties. I'll introduce a config file, when I send a PR to Kernel. > > Both encrypt and decrypt logic should be independent from Carbon. > It is, as of now. > > On Fri, Nov 28, 2014 at 9:45 AM, Nirmal Fernando <[email protected]> wrote: > >> +1 >> >> On Fri, Nov 28, 2014 at 9:37 AM, Afkham Azeez <[email protected]> wrote: >> >>> I think properties file is clean and extensible. All the relevant >>> properties can be seen & configured in one location. >>> >>> On Fri, Nov 28, 2014 at 9:01 AM, Nirmal Fernando <[email protected]> >>> wrote: >>> >>>> Hi Azeez, >>>> >>>> On Fri, Nov 28, 2014 at 8:35 AM, Afkham Azeez <[email protected]> wrote: >>>> >>>>> Have you already started working on this? >>>>> >>>> >>>> Yes, had to provide a support patch. >>>> >>>> >>>>> I would prefer a ciphertool.properties or ciphertool.conf file, rather >>>>> than System properties. >>>>> >>>> >>>> Ciphertool has a ciphertool.sh file to invoke it. That's why I thought >>>> to use System properties. But of course, it's possible to introduce a >>>> properties file. >>>> >>>> >>>>> If the file is not present, fallback to carbon.xml. >>>>> >>>> However, to make this truly independent from Carbon, you should not >>>>> take any dependency on Carbon kernel or components. >>>>> >>>> >>>> Ciphertool has no dependency for any Carbon component/ Kernel. It's >>>> under dependencies and here's the pom file: >>>> https://github.com/wso2/commons/blob/master/ciphertool/pom.xml >>>> >>>>> >>>>> On Thu, Nov 27, 2014 at 11:13 PM, Nirmal Fernando <[email protected]> >>>>> wrote: >>>>> >>>>>> Hi All, >>>>>> >>>>>> Currently, our Cipher tool implementation is dependent upon Carbon >>>>>> runtime specific configuration files such as carbon.xml [1]. >>>>>> >>>>>> The idea is to, let you configure and run Cipher tool by simply >>>>>> setting System properties, so that you can utilize the tool to encrypt >>>>>> passwords even without having a Carbon runtime available. >>>>>> >>>>>> Of course, the current behavior will also be preserved, that is; if >>>>>> the System properties are not present, the required values will be read >>>>>> from the Carbon runtime specific configurations. >>>>>> >>>>>> Please share your thoughts. >>>>>> >>>>>> [1] >>>>>> https://github.com/wso2/commons/blob/master/ciphertool/src/main/java/org/wso2/ciphertool/CipherTool.java#L290 >>>>>> >>>>>> -- >>>>>> >>>>>> Thanks & regards, >>>>>> Nirmal >>>>>> >>>>>> Senior Software Engineer- Platform Technologies Team, WSO2 Inc. >>>>>> Mobile: +94715779733 >>>>>> Blog: http://nirmalfdo.blogspot.com/ >>>>>> >>>>>> >>>>>> >>>>> >>>>> >>>>> -- >>>>> *Afkham Azeez* >>>>> Director of Architecture; WSO2, Inc.; http://wso2.com >>>>> Member; Apache Software Foundation; http://www.apache.org/ >>>>> * <http://www.apache.org/>* >>>>> *email: **[email protected]* <[email protected]> >>>>> * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * >>>>> *http://blog.afkham.org* <http://blog.afkham.org> >>>>> *twitter: **http://twitter.com/afkham_azeez* >>>>> <http://twitter.com/afkham_azeez> >>>>> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >>>>> <http://lk.linkedin.com/in/afkhamazeez>* >>>>> >>>>> *Lean . Enterprise . Middleware* >>>>> >>>> >>>> >>>> >>>> -- >>>> >>>> Thanks & regards, >>>> Nirmal >>>> >>>> Senior Software Engineer- Platform Technologies Team, WSO2 Inc. >>>> Mobile: +94715779733 >>>> Blog: http://nirmalfdo.blogspot.com/ >>>> >>>> >>>> >>> >>> >>> -- >>> *Afkham Azeez* >>> Director of Architecture; WSO2, Inc.; http://wso2.com >>> Member; Apache Software Foundation; http://www.apache.org/ >>> * <http://www.apache.org/>* >>> *email: **[email protected]* <[email protected]> >>> * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * >>> *http://blog.afkham.org* <http://blog.afkham.org> >>> *twitter: **http://twitter.com/afkham_azeez* >>> <http://twitter.com/afkham_azeez> >>> *linked-in: **http://lk.linkedin.com/in/afkhamazeez >>> <http://lk.linkedin.com/in/afkhamazeez>* >>> >>> *Lean . Enterprise . Middleware* >>> >> >> >> >> -- >> >> Thanks & regards, >> Nirmal >> >> Senior Software Engineer- Platform Technologies Team, WSO2 Inc. >> Mobile: +94715779733 >> Blog: http://nirmalfdo.blogspot.com/ >> >> >> >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > Isuru Perera > Senior Software Engineer | WSO2, Inc. | http://wso2.com/ > Lean . Enterprise . Middleware > > about.me/chrishantha > > _______________________________________________ > Architecture mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > > -- Thanks & regards, Nirmal Senior Software Engineer- Platform Technologies Team, WSO2 Inc. Mobile: +94715779733 Blog: http://nirmalfdo.blogspot.com/
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
