Hi, Please find the recommendation for the Shippo connector below. 1. Copyrights headers should be added in each xml configuration files(year should be 2005-2015). 2. The value "v1" should be added to apiUrl. 3. There are unwanted empty lines and spaces in all xml configuration files and java file, there are should be erased. 4. Maintain the wso2 code standard(120 columns). 5. In createShipment method optional parameters are passed directly without checking, It should be checked in the configuration file.
Regards, -- *Naasheer Ali* | Associate Software Engineer WSO2, Inc |#20, Palm Grove, Colombo 03, Sri Lanka Email: [email protected] On Fri, Jan 16, 2015 at 1:43 PM, Vanjikumaran Sivajothy <[email protected]> wrote: > Hi Rasika, > > Can you please give your inside on Kesavan's questions. > Specially on > > Authorization flow is not implemented(OAuth 2-get access token from > the code). > There are empty fields in the sample request of ‘ listCustomers’ ,’ > listFulfillments’,’listOrders’,’’ methods in the documentation. > For the post methods input is received in the json format which is > expected by the back-end and send without any checking for optional > parameters. > Not all optional parameters included in the integration test > > On Fri, Jan 16, 2015 at 1:38 PM, Kesavan Yogarajah <[email protected]> > wrote: > >> Hi >> Please find the comments for the Shopify Connector below. >> >> Authorization flow is not implemented(OAuth 2-get access token from the >> code). >> No copyright header in xml configuration files. >> The year should be 2005-2015 in copyright header in the >> ShopifyConnectorIntegrationTest.java file. >> There are empty fields in the sample request of ‘ listCustomers’ ,’ >> listFulfillments’,’listOrders’,’’ methods in the documentation. >> For the post methods input is received in the json format which is >> expected by the back-end and send without any checking for optional >> parameters. >> Not all optional parameters included in the integration test >> >> >> >> Kesavan Yogarajah >> Associate Software Engineer >> WSO2 Inc. >> >> Mob: +94 779758021 >> >> On Thu, Oct 30, 2014 at 11:22 AM, Rasika Hettige <[email protected]> >> wrote: >> >>> Hi, >>> >>> FFI, following methods will be implemented under following connectors: >>> >>> *Shopify Connector* >>> >>> createCustomer - Creates a new customer record >>> listCustomers - Retrieves all customers of a shop >>> getProductById - Retrieves a single product >>> listProducts - Retrieves a list of products >>> createProduct - Creates a new product >>> createProductVariant - Creates a new product variant >>> listProductVariants - Retrieves a list of product variants >>> createOrder - Creates a new order >>> listOrders - Retrieves a list of Orders according to the given filters >>> createFulfillment - Creates a fulfillment for the specified order and >>> line >>> items >>> listFulfillments -Retrieves a list of all fulfillments >>> >>> *MailChimp Connector* >>> >>> createDraftCampaign - Create a new draft campaign to send >>> sendCampaign - Send a given campaign immediately >>> listCampaigns - Get the list of campaigns and their details matching the >>> specified filters >>> createTemplate - Create a new user template which can be applied while >>> creating campaigns >>> listTemplates - Retrieve various templates available in the system >>> listSubscriberLists - Retrieve all the lists defined for the user account >>> addSubscribersToList - Subscribe a batch of email addresses to a list at >>> once >>> listCampaignClicks - Lists the urls tracked and their click counts for a >>> given campaign >>> listCampaignClickers - Return the list of email addresses that clicked >>> on a >>> given url, and how many times they clicked >>> listCampaignOpeners - Retrieve the list of email addresses that opened a >>> given campaign with how many times they opened >>> >>> *Shippo Connector* >>> >>> createAddress - Creates a new address object >>> createShipment - Creates a new shipment object >>> listAddresses - Lists all addresses >>> listShipments - Lists all shipment objects >>> createCustomsItem - Creates a new Customs Item object >>> listCustomsItems - Lists all custom-items objects >>> createCustomsDeclaration - Creates a new Customs Declaration object >>> listTransactions - Lists all transaction objects >>> >>> >>> *ZohoCRM Connector* >>> >>> searchRecords - To get the list of records that meets the specified >>> search >>> criteria. >>> >>> Thanks & Regards >>> Rasika >>> >>> >>> >>> -- >>> View this message in context: >>> http://wso2-oxygen-tank.10903.n7.nabble.com/Proposed-ESB-connector-scenario-Integrating-Shopify-with-MailChimp-Facebook-ZohoCRM-CallRail-and-Shi-tp104656p106173.html >>> Sent from the WSO2 Architecture mailing list archive at Nabble.com. >>> _______________________________________________ >>> Architecture mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >> >> > > > -- > Sivajothy Vanjikumaran > *Senior Software Engineer* > *Integration Technologies Team* > *WSO2 Inc. http://wso2.com <http://wso2.com/>* > *Mobile:(+94)777219209* > [image: Facebook] <https://www.facebook.com/vanjikumaran> [image: Twitter] > <https://twitter.com/vanjikumaran> [image: LinkedIn] > <http://www.linkedin.com/pub/vanjikumaran-sivajothy/25/b31/293> [image: > Blogger] <http://vanjikumaran.blogspot.com/> [image: SlideShare] > <http://www.slideshare.net/vanjikumaran> > > This communication may contain privileged or other > confidential information and is intended exclusively for the addressee/s. > If you are not the intended recipient/s, or believe that you may > have received this communication in error, please reply to the > sender indicating that fact and delete the copy you received and in > addition, you should not print, copy, re-transmit, disseminate, or > otherwise use the information contained in this communication. > Internet communications cannot be guaranteed to be timely, secure, error > or virus-free. The sender does not accept liability for any errors > or omissions > > _______________________________________________ > Architecture mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > >
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
