Hi Chathura/Ruwan, Its debatable with pros & cons at both edges. We initially designed this to separate social aspects from the store. Other than that I don't have any objection for your suggestions.
@Manu WDYT? (Even if we are to merge social app with store we won't be able to it right now. We are to release ES2 this week with the current design.) On Mon, Aug 31, 2015 at 11:56 AM, Chathura Dilan <[email protected]> wrote: > Hi Udara, > > Although the ES social framework is an implementation of activity stream, > I think that the commenting and ratings UI should be a part of store. Store > UI can communicate with the social framework components to post comments > and render UIs accordingly rather than having a separate UI for social > framework because it is more generic. > > > > On Mon, Aug 31, 2015 at 10:43 AM, Udara Rathnayake <[email protected]> > wrote: > >> >> >> On Mon, Aug 31, 2015 at 10:36 AM, Chathura Dilan <[email protected]> >> wrote: >> >>> Hi Udara, >>> >>> Since this component is a part of the store, I believe we should >>> incorporate it into the store. There is no reuse of the social app other >>> than the store. >>> >> ATM yes, But by providing generic Target, Actor, Activity objects social >> app can be plugged anywhere. Social framework is a implementation of >> http://activitystrea.ms/specs/json/1.0/ >> >>> >>> On Mon, Aug 31, 2015 at 10:19 AM, Udara Rathnayake <[email protected]> >>> wrote: >>> >>>> Hi Chathura, >>>> >>>> On Mon, Aug 31, 2015 at 8:13 AM, Chathura Dilan <[email protected]> >>>> wrote: >>>> >>>>> Hi All, >>>>> >>>>> Currently app manager have a commenting and rating component bases on >>>>> ES social app. Social is a separate app and it is included in App Manager >>>>> store using an iframe. This leads to some issues. >>>>> >>>>> 1. AppM store average rating is not updated once the use add a rating >>>>> to the app. >>>>> >>>> Are you talking about the real time update between social app and store >>>> ? >>>> >>>>> 2. Any user can add comments to any app regardless of the subscription. >>>>> >>>> Do we need to check subscription to particular app before adding a >>>> comment / rating ? . We can improve social app to accommodate above . >>>> >>>>> 3. When user visit to an app, commenting is not getting loaded due to >>>>> social app authentication. >>>>> >>>> This happens when we load store app & social iframe using different >>>> host names (eg localhost & IP ) . When we configure ES to use proper domain >>>> this should be fixed . >>>> >>>>> >>>>> Hence the solution is to include the social component in AppM store >>>>> itself. >>>>> >>>>> Your ideas and suggestions would be highly appreciated. >>>>> >>>> Let's improve existing application. >>>> >>>>> >>>>> Thanks >>>>> >>>>> -- >>>>> Regards, >>>>> >>>>> Chatura Dilan Perera >>>>> *Senior Software Engineer** - WSO2 Inc.* >>>>> www.dilan.me >>>>> >>>> >>>> >>> >>> >>> -- >>> Regards, >>> >>> Chatura Dilan Perera >>> *Senior Software Engineer** - WSO2 Inc.* >>> www.dilan.me >>> >> >> > > > -- > Regards, > > Chatura Dilan Perera > *Senior Software Engineer** - WSO2 Inc.* > www.dilan.me >
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
