Hi All,

This is regarding the improvement suggested at [1].

Currently when committing changes of a App Factory project via Developer
Studio, it by default sets author details that are taken from global git
configuration file (.gitconfig file). This file is created while setting up
git for the first time[2].
However, if author details are also configured in project specific git
config file (<project-root>/.git/config) - EGit will use those values for
Author tag instead of the global properties. Furthermore, If both global
and project specific configurations does not contain these properties, EGit
will prompt a wizard to setup global author details. This is the behavior
of Eclipse git plugin[3].

To solve the problem at hand, we can configure author details in the
project specific git config file while doing the initial checkout from app
factory. This will make sure that EGit will always put author details
matching to the App Factory user who did the initial checkout.

However, the question is "Do we really need to make these author details
non-editable?".
As with the above proposed implementation, it is not possible to achieve
this. The reason is, after checking out and importing a project into
work-space, we do not have a control in git related functionalities. It's
the EGit plugin which provides these features and it allows user to alter
author details while committing or through preferences.

I feel that making author details non-editable is not required for the
reason the AF doesn't restrict pushing commits from different authors(it
doesn't validate authenticated user with commit authors). Even if it does,
it's the responsibility of the developer to manage that. WDYT?

Thanks,

[1] https://wso2.org/jira/browse/TOOLS-2728
[2] https://git-scm.com/book/en/v2/Getting-Started-First-Time-Git-Setup
[3] http://www.eclipse.org/egit/

-- 
*Kavith Lokuhewage*
Software Engineer
WSO2 Inc. - http://wso2.com
lean . enterprise . middleware
Mobile - +9477-9-145-123 | +9471-455-6-401
Linkedin <http://www.linkedin.com/pub/kavith-lokuhewage/49/473/419>  Twitter
<https://twitter.com/KavithThiranga>
_______________________________________________
Architecture mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture

Reply via email to