Hi Samiyuru, Can you check with Netty-http developers as to why they had made these constraints? They must had a good reason to introduce a parent class etc. We should find what it is to fix it on our end.
On Wed, Sep 23, 2015 at 11:21 AM, Afkham Azeez <[email protected]> wrote: > I have forked the code at https://github.com/wso2/product-mss/. Let's > optimize it for our use cases not worrying too much about doing > non-backward compatible changes. > > Azeez > > On Mon, Sep 21, 2015 at 5:01 PM, Samiyuru Senarathne <[email protected]> > wrote: > >> Hi, >> >> In MSS based on Carbon 5, netty-http is used on top of netty for the >> JAX-RS engine. Here, netty-http provides JAX-RS annotation processing >> functionality using reflection. But the way that netty-http supports JX-RS >> resource classes is bit too much coupled with netty-http implementation. >> >> IE in netty-http: >> >> 1. >> >> All resource classes should implement co.cask.http.HttpHandler >> interface. >> 2. >> >> First two parameters of all resource methods must be >> io.netty.handler.codec.http.HttpRequest and co.cask.http.HttpResponder >> 3. >> >> No support for javax.ws.rs.core.Context >> >> In addition to that, there are few missing features in netty-http that we >> need in MSS that should be implemented in netty-http side. >> >> Therefore, in order to use netty-http in MSS, multiple changes have to be >> done to the netty-http library. In this case, >> >> 1. >> >> We can do the changes and send pull request. >> 2. >> >> Or we can maintain our own code base. >> >> >> What do you think about these concerns? >> >> Thank you. >> -- >> Samiyuru Senarathne >> *Software Engineer* >> Mobile : +94 (0) 71 134 6087 >> [email protected] >> > > > > -- > *Afkham Azeez* > Director of Architecture; WSO2, Inc.; http://wso2.com > Member; Apache Software Foundation; http://www.apache.org/ > * <http://www.apache.org/>* > *email: **[email protected]* <[email protected]> > * cell: +94 77 3320919 <%2B94%2077%203320919>blog: * > *http://blog.afkham.org* <http://blog.afkham.org> > *twitter: **http://twitter.com/afkham_azeez* > <http://twitter.com/afkham_azeez> > *linked-in: **http://lk.linkedin.com/in/afkhamazeez > <http://lk.linkedin.com/in/afkhamazeez>* > > *Lean . Enterprise . Middleware* > -- *Kasun Gajasinghe*Senior Software Engineer, WSO2 Inc. email: kasung AT spamfree wso2.com linked-in: http://lk.linkedin.com/in/gajasinghe blog: http://kasunbg.org
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
