On Fri, Mar 25, 2016 at 11:11 AM, Manuranga Perera <[email protected]> wrote:
> Yes, this is an option but I don't see any big differences from this to
>> the approach we currently use.
>
> I agree there is no functional advantage, but it will make the pom looks
> nicer with less redundancy, subjectively speaking.
>
> At least shouldn't we keep the same convention across all poms not just
> OSGi poms. Currently we have both conventions even in the same repository
> [1] [2].
>
The convention we followed in carbon-kernel is that for packing pom we use
<artifactId>carbon-kernel-parent</artifactId>
For the packing bundles, we've used,
<artifactId>org.wso2.carbon.core</artifactId>
> [1] https://github.com/wso2/carbon-kernel/blob/master/pom.xml#L26
> [2] https://github.com/wso2/carbon-kernel/blob/master/core/pom.xml#L28
>
> On Fri, Mar 25, 2016 at 9:10 AM, Kishanthan Thangarajah <
> [email protected]> wrote:
>
>>
>>
>> On Fri, Mar 25, 2016 at 12:44 AM, Manuranga Perera <[email protected]> wrote:
>>
>>> Our current naming convention [1] looks like:
>>> <groupId>org.wso2.carbon</groupId>
>>> <artifactId>org.wso2.carbon.core</artifactId>
>>>
>>> But I believe it should be like (and maven recommended [2]):
>>> <groupId>org.wso2.carbon</groupId>
>>> <artifactId>kernel</artifactId>
>>>
>>> (I see the second patten in some C5 based code [3]. So not sure which
>>> one is the convention.)
>>>
>>
>> The reason we use the first is that, we are following equinox bundle
>> naming convention (and most of the apache OSGi related projects uses the
>> same convention) and also to avoid any duplication of bundle names with
>> OSGi runtime.
>>
>>
>>> One issue with the second approach is, there is a risk of Bundle-Name
>>> not being unique since we currently use "${project.artifactId}" as the
>>> Bundle-Name. But we can easily use something like "
>>> ${project.artifactId}.${project.groupId}" instead.
>>>
>>
>> Yes, this is an option but I don't see any big differences from this to
>> the approach we currently use.
>>
>>
>>> What do you think ?
>>>
>>> [1] https://github.com/wso2/carbon-kernel/blob/master/core/pom.xml#L28
>>> [2] https://maven.apache.org/guides/mini/guide-naming-conventions.html
>>> [3]
>>> https://github.com/wso2/msf4j/blob/master/analytics/msf4j-analytics/pom.xml#L29
>>> --
>>> With regards,
>>> *Manu*ranga Perera.
>>>
>>> phone : 071 7 70 20 50
>>> mail : [email protected]
>>>
>>
>>
>>
>> --
>> *Kishanthan Thangarajah*
>> Associate Technical Lead,
>> Platform Technologies Team,
>> WSO2, Inc.
>> lean.enterprise.middleware
>>
>> Mobile - +94773426635
>> Blog - *http://kishanthan.wordpress.com
>> <http://kishanthan.wordpress.com>*
>> Twitter - *http://twitter.com/kishanthan <http://twitter.com/kishanthan>*
>>
>
>
>
> --
> With regards,
> *Manu*ranga Perera.
>
> phone : 071 7 70 20 50
> mail : [email protected]
>
> _______________________________________________
> Architecture mailing list
> [email protected]
> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
>
>
--
*Aruna Sujith Karunarathna *
WSO2, Inc | lean. enterprise. middleware.
#20, Palm Grove, Colombo 03, Sri Lanka
Mobile: +94 71 9040362 | Work: +94 112145345
Email: [email protected] | Web: www.wso2.com
_______________________________________________
Architecture mailing list
[email protected]
https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
