+1 for the approach, given the handler is written for REST service artifacts.
Shazni Nazeer Mob : +94 777737331 LinkedIn : http://lk.linkedin.com/in/shazninazeer Blog : http://shazninazeer.blogspot.com On Mon, Apr 18, 2016 at 9:21 AM, Rajith Roshan <[email protected]> wrote: > Hi Madawa, > > By adding this handler we will have consistency when creating a soap > service manually specifying the wsdl url (which invokes > SOAPServiceMediaTypeHandler) and creating a rest service manually > specifying the wadl/swagger url. > And it will also import additional schemas and create the respective > endpoints as well (when WADLProcessor and SwaggerProcessor are used). So > this will enable better dependency visualization as well. > > +1 > > Further, current implementation will import wadl content to the registry, > if the wadl url is given when creating a soap service. It is better to, > only import the wadl content when creating rest service through your newly > introduced handler. WDYT ? > > Thanks! > Rajith > > On Mon, Apr 18, 2016 at 2:11 PM, Madawa Soysa <[email protected]> wrote: > >> Hi Shazni, >> >> In addition, all the handling logic for Swagger and WADL documents will >> be done using the existing swagger and WADL processor methods. >> Implementation of new media type handler will be needed to invoke these >> methods when a rest service artifact is added through the Governance Center >> Publisher. >> >> Regards, >> Madawa. >> >> On Mon, Apr 18, 2016 at 2:05 PM, Madawa Soysa <[email protected]> wrote: >> >>> Hi Shazni, >>> >>> Thank you for the feedback. >>> >>> Actually, I'm trying to implement a media type handler when *adding a >>> REST service artifact* through the Governance Center Publisher. >>> >>> Currently, there is no media type handler to handle manually added rest >>> service artifacts through the publisher and these are handled by the >>> default handler. That's why I suggested implementing a media type handler >>> as similar to the SOAP Service media type handler. >>> >>> Regards, >>> Madawa. >>> >>> >>> On Sun, Apr 17, 2016 at 7:48 AM, Shazni Nazir <[email protected]> wrote: >>> >>>> Hi Madawa, >>>> >>>> IMO, we do not need a separate media type handler for this. Reason >>>> being a media type handler for a REST call doesn't seem correct. Rather >>>> what we need is a method to take the URL etc to utilize the methods in WADL >>>> and swagger processor. WDYT?? >>>> >>>> Using existing swagger and WADL processor however seems the right >>>> approach for consistency without rewriting all the code again. >>>> >>>> Shazni Nazeer >>>> Mob : +94 777737331 >>>> LinkedIn : http://lk.linkedin.com/in/shazninazeer >>>> Blog : http://shazninazeer.blogspot.com >>>> >>>> On Fri, Apr 8, 2016 at 12:22 AM, Madawa Soysa <[email protected]> wrote: >>>> >>>>> Hi, >>>>> >>>>> I have started improving the REST Service artifact handling capability >>>>> in GREG[1] <https://wso2.org/jira/browse/REGISTRY-3532>. In the >>>>> current implementation, when a REST Service is added manually and if a >>>>> Swagger or WADL resource URL is given, the resource will not get uploaded >>>>> to the system and the relevant associations will not get created. The >>>>> purpose of this improvement is to fix the above issue. >>>>> >>>>> My approach to solving this issue is by writing a separate media type >>>>> handler to handle REST service artifact and use existing swagger and WADL >>>>> processors to import the specified resource. Any suggestions and feedback >>>>> are appreciated. >>>>> >>>>> >>>>> [1] - https://wso2.org/jira/browse/REGISTRY-3532 >>>>> >>>>> Regards, >>>>> Madawa >>>>> -- >>>>> >>>>> Madawa Soysa / Software Engineer >>>>> [email protected] / +94714616050 >>>>> >>>>> WSO2 Inc. >>>>> lean.enterprise.middleware >>>>> >>>>> [image: Twitter] <https://twitter.com/madawa_rc> [image: >>>>> LinkedIn] <https://www.linkedin.com/in/madawasoysa> [image: Github] >>>>> <https://github.com/madawas> [image: Tumblr] >>>>> <http://madawas.tumblr.com/> >>>>> >>>>> _______________________________________________ >>>>> Architecture mailing list >>>>> [email protected] >>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>> >>>>> >>>> >>>> _______________________________________________ >>>> Architecture mailing list >>>> [email protected] >>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>> >>>> >>> >>> >>> -- >>> >>> Madawa Soysa / Software Engineer >>> [email protected] / +94714616050 >>> >>> WSO2 Inc. >>> lean.enterprise.middleware >>> >>> [image: Twitter] <https://twitter.com/madawa_rc> [image: >>> LinkedIn] <https://www.linkedin.com/in/madawasoysa> [image: Github] >>> <https://github.com/madawas> [image: Tumblr] >>> <http://madawas.tumblr.com/> >>> >> >> >> >> -- >> >> Madawa Soysa / Software Engineer >> [email protected] / +94714616050 >> >> WSO2 Inc. >> lean.enterprise.middleware >> >> [image: Twitter] <https://twitter.com/madawa_rc> [image: >> LinkedIn] <https://www.linkedin.com/in/madawasoysa> [image: Github] >> <https://github.com/madawas> [image: Tumblr] >> <http://madawas.tumblr.com/> >> >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > Rajith Roshan > Software Engineer, WSO2 Inc. > Mobile: +94-72-642-8350 <%2B94-71-554-8430> >
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
