Hi all,
On Tue, Jul 12, 2016 at 8:14 AM, Joseph Fonseka <[email protected]> wrote: > Hi Isura > > A minor suggestions to make the interface intuitive. > > * Instead of PUT "recover-password" introduce a new processing function > POST "set-password". The parameters can be the same. > - This will avoid using a PUT for a partial update which actually > should be a PATCH but in this case processing function is more appropriate. > +1. Modifed the swagger file according to this. We had the review session with following participants. We could identify some of the resource paths improvements and error code improvements during the session. You can find the attached updated swagger file for more details. Participants : Prabath, Sanjeewa, Darshana, Harsha, Isura Thanks Isura > > Thanks > Jo > > On Mon, Jul 11, 2016 at 10:33 AM, Isura Karunaratne <[email protected]> > wrote: > >> Hi Sanjeewa, >> >> On Mon, Jul 11, 2016 at 10:24 AM, Sanjeewa Malalgoda <[email protected]> >> wrote: >> >>> @Isura, >>> Can you arrange a review session for this? >>> >> Sure. I will arrage. >> >> Thanks >> Isura >> >>> >>> Thanks, >>> sanjeewa. >>> >>> On Thu, Jul 7, 2016 at 5:34 PM, Isura Karunaratne <[email protected]> >>> wrote: >>> >>>> >>>> Hi all, >>>> >>>> Following are the new rest API implementation [1] that we have >>>> developed for IS 5.3.0 m2 . We are in the process of refactoring and model >>>> the APIs using swagger. You can find the attached swagger definition that >>>> we have developed. >>>> >>>> Your comments and suggestions are highly appreciated.Recover with >>>> Notification >>>> >>>> - >>>> >>>> sendRecoveryNotification() : validate user and returns a new key >>>> through a notification. >>>> - >>>> >>>> updatePassword() : Updates the password in the system. Need to >>>> provide the key from notification, new password >>>> >>>> >>>> Recover with Secret Questions >>>> >>>> - >>>> >>>> intiateUserChallengeQuestion(); validate user and returns a >>>> question to answer with a secret code >>>> - >>>> >>>> verifyUserChallengeAnswer(); validate secret code and answer for >>>> the question in previous step. Return a new question with new secret >>>> until >>>> the minimum number of questions are answered. >>>> - >>>> >>>> updatePassword(); Updates the password in the system. Need to >>>> provide the key from notification, new password >>>> >>>> >>>> >>>> New APIs for Multiple Questions at once >>>> >>>> - >>>> >>>> getAllChallegeQuestions(); validate user and returns all questions >>>> to answer with a secret code >>>> - >>>> >>>> validateAllChallengeAnswers(); validate code and all answers and >>>> return a code if success >>>> - >>>> >>>> updatePassword();Updates the password in the system. Need to >>>> provide the key from notification, new password >>>> >>>> >>>> >>>> [1] Identity Management Recovery API improvements >>>> >>>> >>>> -- >>>> Isura Dilhara Karunaratne >>>> Senior Software Engineer >>>> >>>> Mob +94 772 254 810 >>>> >>>> >>> >>> >>> -- >>> >>> *Sanjeewa Malalgoda* >>> WSO2 Inc. >>> Mobile : +94713068779 >>> >>> <http://sanjeewamalalgoda.blogspot.com/>blog >>> :http://sanjeewamalalgoda.blogspot.com/ >>> <http://sanjeewamalalgoda.blogspot.com/> >>> >>> >>> >> >> >> -- >> Isura Dilhara Karunaratne >> Senior Software Engineer >> >> Mob +94 772 254 810 >> >> > > > -- > > -- > *Joseph Fonseka* > WSO2 Inc.; http://wso2.com > lean.enterprise.middleware > > mobile: +94 772 512 430 > skype: jpfonseka > > * <http://lk.linkedin.com/in/rumeshbandara>* > > -- Isura Dilhara Karunaratne Senior Software Engineer Mob +94 772 254 810
wso2_recovery-api.yaml
Description: application/yaml
wso2_recovery-api.json
Description: application/json
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
