Hi, I also don't think that we should use samples as a "feature" in our product. I also don't think that we should give a script to download samples later. That will be a problem if there is no Internet connectivity.
I think we should include samples in the product, but maintain samples only in one repository. For that, we can deploy samples to maven as a zip. For example, ML can deploy a sample to Maven Repository and DAS product can simply use the ML sample as a dependency. DAS can unzip the sample dependency and copy to the product distribution when building with Maven. For example, I deploy Metrics CAR file to Maven [1] and Analytics MB product just uses that as a Maven Dependency [2]. [1] https://github.com/wso2/carbon-metrics/blob/v2.0.0/components/org.wso2.carbon.metrics.das.capp/src/assembly/capp.xml [2] https://github.com/wso2/analytics-mb/blob/v3.2.0-M1/features/org.wso2.analytics.mb.feature/pom.xml#L49-L73 On Tue, Aug 2, 2016 at 11:00 AM, Rasika Perera <[email protected]> wrote: > IMO Adding samples as a feature will *misuse* the concept of a feature. > Samples are not features of the product. > > How about packing a script with the product that would download samples > from a git repo. We can make the script to download *only* the relevant > branch from the samples repo. > > For instance; > > git clone -b release-1.0.0-[version] --single-branch > https://github.com/wso2/<sample-repo>.git > > > This approach have several advantages; > > 1. It will create a connection between samples' version and product > release version that will make sure the samples are always compatible with > the given product release. > > 2. Samples does not add any weight into the product distribution running > on production environment. > > 3. Even after the product release, If any issue found with a sample can > add fixes and can add new samples for compatible versions. > > PS: we can install `git` if it does not exists; from the same script(.bat > , .sh). > > > On Mon, Aug 1, 2016 at 11:42 PM, Mohanadarshan Vivekanandalingam < > [email protected]> wrote: > >> Hmm, I am not against for shipping samples with product distribution.. >> But it is not a scalable solution anymore.. When platform story grows we >> are tend to reuse features the shipping all the sample within a product >> distribution is not scale.. >> >> IMHO, samples are used in development stages and installing svn or git in >> that case does not cause any concerns.. If we want to debug and verify the >> functionality then can't we simply copy the samples and tryout?.. >> >> Thanks, >> Mohan >> >> >> On Mon, Aug 1, 2016 at 5:00 PM, Gihan Anuruddha <[email protected]> wrote: >> >>> I see two downsides from above approach. >>> >>> 1. Users have to install svn or git in their machine (This is a small >>> issue, but unnecessary dependency). >>> 2. Sometimes when we are facing some issues, easiest way for us is, run >>> the sample and see things are working fine. Specially in a remote machine. >>> We lose that freedom. >>> >>> Above are minor problems. But bit inconvenient for end users. >>> >>> Regards, >>> Gihan >>> >>> On Mon, Aug 1, 2016 at 4:32 PM, Mohanadarshan Vivekanandalingam < >>> [email protected]> wrote: >>> >>>> >>>> >>>> On Mon, Aug 1, 2016 at 4:02 PM, Niranda Perera <[email protected]> >>>> wrote: >>>> >>>>> Hi all, >>>>> >>>>> At the moment we are maintaining samples of DAS, CEP and ML in their >>>>> own product repos. Since, DAS integrates both CEP and ML, we need to send >>>>> these samples with DAS. >>>>> >>>>> Currently we do so for ML samples, but the approach we are using is to >>>>> keep a local copy of the samples in the product-das repo. This approach is >>>>> rather problematic, because when there are changes in the original >>>>> samples, >>>>> we would also have to reflect those changes manually in the product-das >>>>> copy. >>>>> >>>>> Is there a more consistent way to add samples? May be like creating a >>>>> separate samples feature? >>>>> >>>> >>>> IMO, best option is remove samples from product distribution and >>>> maintain in a common location (svn or git). In this case, whoever like try >>>> the samples can refer relevant locations.. >>>> >>>> This is also give us a freedom to add/update samples time to time >>>> without worrying about product releases.. >>>> >>>> Thanks, >>>> Mohan >>>> >>>> >>>>> >>>>> Would like to hear from you regarding this. >>>>> >>>>> Best >>>>> >>>>> -- >>>>> *Niranda Perera* >>>>> Software Engineer, WSO2 Inc. >>>>> Mobile: +94-71-554-8430 >>>>> Twitter: @n1r44 <https://twitter.com/N1R44> >>>>> https://pythagoreanscript.wordpress.com/ >>>>> >>>>> _______________________________________________ >>>>> Architecture mailing list >>>>> [email protected] >>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>> >>>>> >>>> >>>> >>>> -- >>>> *V. Mohanadarshan* >>>> *Associate Tech Lead,* >>>> *Data Technologies Team,* >>>> *WSO2, Inc. http://wso2.com <http://wso2.com> * >>>> *lean.enterprise.middleware.* >>>> >>>> email: [email protected] >>>> phone:(+94) 771117673 >>>> >>>> _______________________________________________ >>>> Architecture mailing list >>>> [email protected] >>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>> >>>> >>> >>> >>> -- >>> W.G. Gihan Anuruddha >>> Senior Software Engineer | WSO2, Inc. >>> M: +94772272595 >>> >>> _______________________________________________ >>> Architecture mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >>> >> >> >> -- >> *V. Mohanadarshan* >> *Associate Tech Lead,* >> *Data Technologies Team,* >> *WSO2, Inc. http://wso2.com <http://wso2.com> * >> *lean.enterprise.middleware.* >> >> email: [email protected] >> phone:(+94) 771117673 >> >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > > -- > With Regards, > > *Rasika Perera* > Software Engineer > LinkedIn: http://lk.linkedin.com/in/rasika90 > > [image: wso2-signature-general.png] <https://wso2.com/signature> > > WSO2 Inc. www.wso2.com > lean.enterprise.middleware > > _______________________________________________ > Architecture mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > > -- Isuru Perera Associate Technical Lead | WSO2, Inc. | http://wso2.com/ Lean . Enterprise . Middleware about.me/chrishantha Contact: +IsuruPereraWSO2 <https://www.google.com/+IsuruPereraWSO2/about>
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
