Hi Isuru, IMHO, if the carbon metrics initializing time do not change the existing startup time by a quite margin, that would be ok. At the moment it is about 200 - 300ms for a simple service. Do we know that additional overhead that will bring the startup?
Thanks Thusitha On Mon, Aug 8, 2016 at 8:58 AM, Isuru Perera <[email protected]> wrote: > MSF4J Team, WDYT on $subject? > > On Thu, Aug 4, 2016 at 9:13 AM, Isuru Perera <[email protected]> wrote: > >> Hi Ramith, >> >> >> On Wed, Aug 3, 2016 at 6:35 PM, Ramith Jayasinghe <[email protected]> >> wrote: >> >>> HI Isuru, >>> Could you ellaborate on "define their own Metrics and let them use the >>> MetricService directly". >>> >> This means that the users can create Metrics using their own names. This >> doesn't mean that they can create different types of metrics. >> >> What I want in MSF4J is to support Metrics directly instead of just using >> annotations on service methods. >> >>> Does that mean we get to define different types of matrices and >>> register them with carbon-metrics and then use? ( apart from standard >>> metrics such as Avg, std-deviations etc). >>> If so we have some use cases which benefits from a similar concept. >>> >>> On Tue, Aug 2, 2016 at 12:02 PM, Isuru Perera <[email protected]> wrote: >>> >>>> Hi, >>>> >>>> Currently in MSF4J, the Carbon Metrics is lazily initialized when a >>>> service method with a Metrics Annotation [1] is invoked. >>>> >>>> However the Carbon Metrics also registers some JVM metrics (heap >>>> usages, thread counts, cpu load etc). These metrics will be available only >>>> after initialization. I think these JVM metrics are useful to the user even >>>> if they are not using any Metrics annotations. >>>> >>>> I also think we should let user to define their own Metrics and let >>>> them use the MetricService directly. Even now they can use it, but it's >>>> only initialized when it's used for the first time. >>>> >>>> I think we should initialize the Metrics at MSF4J startup. So, if a >>>> user added MSF4J Analytics dependency, we can initialize Metrics. For this, >>>> we also need a way to register some callback function, which will be called >>>> during MSF4J startup. >>>> >>>> WDYT? >>>> >>>> [1] https://github.com/wso2/msf4j#metrics-annotations >>>> >>>> -- >>>> Isuru Perera >>>> Associate Technical Lead | WSO2, Inc. | http://wso2.com/ >>>> Lean . Enterprise . Middleware >>>> >>>> about.me/chrishantha >>>> Contact: +IsuruPereraWSO2 >>>> <https://www.google.com/+IsuruPereraWSO2/about> >>>> >>>> _______________________________________________ >>>> Architecture mailing list >>>> [email protected] >>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>> >>>> >>> >>> >>> -- >>> Ramith Jayasinghe >>> Technical Lead >>> WSO2 Inc., http://wso2.com >>> lean.enterprise.middleware >>> >>> E: [email protected] >>> P: +94 772534930 >>> >>> _______________________________________________ >>> Architecture mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >>> >> >> >> -- >> Isuru Perera >> Associate Technical Lead | WSO2, Inc. | http://wso2.com/ >> Lean . Enterprise . Middleware >> >> about.me/chrishantha >> Contact: +IsuruPereraWSO2 <https://www.google.com/+IsuruPereraWSO2/about> >> > > > > -- > Isuru Perera > Associate Technical Lead | WSO2, Inc. | http://wso2.com/ > Lean . Enterprise . Middleware > > about.me/chrishantha > Contact: +IsuruPereraWSO2 <https://www.google.com/+IsuruPereraWSO2/about> > -- Thusitha Dayaratne Software Engineer WSO2 Inc. - lean . enterprise . middleware | wso2.com Mobile +94712756809 Blog alokayasoya.blogspot.com About http://about.me/thusithathilina <http://wso2.com/signature>
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
