Hi Lakshani, IIRC this feature was developed long time back. It would have been ideal if the PR was sent at that time itself for 5.2.0 branch and merged. Now 5.2.0 is in beta stage and not ideal to merge this improvement. However since this is critical for AppManger and we are not quite certain on the next IS release, we will check the possibilities of merging this.
First of all the PR seems to be conflicted. Please fix it and send a new PR to the relevant repo. We don't use carbon-identity any more. Then make sure the feature is completely backward compatible and has no schema changes, API changes and migration steps involved. Right now we are fixing L1/L2/L3 for IS 5.2.0 RC. So we don't want any major changes in existing features. If you can make sure above are satisfied we can check the possibilities of merging it. Regards, Johann. On Mon, Aug 15, 2016 at 4:46 PM, Lakshani Gamage <[email protected]> wrote: > Hi Johann/Darshana, > > This feature implementation is completed in [1]. But for 5.1.0 release > this feature wasn't add, as it was not good to add new feature in that > stage of IS branch and discussed to try to add this to next release. > So,could you please add this feature to 5.2.0 release as we are hoping to > add bulk subscription feature to App Manage. > > [1] https://github.com/wso2/carbon-identity/compare/ > master...lakshani:bulk_subscription > > Thanks, > Lakshani > > On Mon, Sep 28, 2015 at 2:25 PM, Lakshani Gamage <[email protected]> > wrote: > >> >> On Mon, Sep 28, 2015 at 12:30 PM, Lakshani Gamage <[email protected]> >> wrote: >> >>> Hi all, >>> >>> These are the design decisions taken in database modification discussion. >>> >>> *In IS Point of View,* >>> >>> - When a new XACML policy is being added, user can define, for which >>> SP-IDP combination the XACML policy is valid. (We can define valid policy >>> SP-IDP combinations in the "target" tag in policy. eg : <Target >>> ValidSpIdpId="SpId_IdpId"> >>> >>> >> Is SP-IDP combination a unique combination in all scenarios ? >> >>> Yes. It is a unique combination. SP Id value and IDP Id values are >>> unique for all scenarios. >> >> >> Regards, >> Lakshani. >> > > > > -- > Lakshani Gamage > > *Software Engineer, WSO2* > > *Mobile : +94 71 5478184 <%2B94%20%280%29%20773%20451194>* > *Blog : http://lakshanigamage.blogspot.com/ > <http://lakshanigamage.blogspot.com/>* > -- Thanks & Regards, *Johann Dilantha Nallathamby* Technical Lead & Product Lead of WSO2 Identity Server Governance Technologies Team WSO2, Inc. lean.enterprise.middleware Mobile - *+94777776950* Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>*
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
