Jo, Lasantha, CSS selectors e.g. div > p won't work if we forcefully insert a div in the middle. Therefore we shouldn't use divs (or spans) to wrap the content of a zone. Also, there is no need to wrap the content of a zone with anything. We just need to know the start and the end of the zone's content. Hence I believe HTML comments are more suitable.
Thanks. On Wed, Dec 14, 2016 at 12:31 PM, Lasantha Samarakoon <[email protected]> wrote: > Agreeing with Jo. > > Plus the comments have different meaning rather than marking sections, I > don't think it's a good practice to use comments to replace DIVs and other > block elements. If we can go ahead with DIVs other than comments we don't > need to filter nodes in the DOM to identify comment blocks as well. Instead > we can use whatever the available HTML attributes and "data-" attributes. > > Regards, > > *Lasantha Samarakoon* | Software Engineer > WSO2, Inc. > #20, Palm Grove, Colombo 03, Sri Lanka > Mobile: +94 (71) 214 1576 <+94%2071%20214%201576> > Email: [email protected] > Web: www.wso2.com > > lean . enterprise . middleware > > On Wed, Dec 14, 2016 at 10:47 AM, Joseph Fonseka <[email protected]> wrote: > >> Hi Sajith >> >> On Wed, Dec 14, 2016 at 8:44 AM, SajithAR Ariyarathna <[email protected]> >> wrote: >> >>> >>> 2. Why did we use comments to propagate Zones to the client side instead >>>> of Divs. >>>> >>> divs clashes with CSS selectors (same goes for spans). These zone >>> markers should be invisible (which means they shouldn't create or affect >>> visual elements in the DOM). That's' why we chose HTML comments. >>> >> >> I am not sure if the above claim is correct. If Divs are not specifically >> styled it should not clash with CSS. Divs are meant to encapsulate >> a division or a section in the HTML which I believe what zone also >> represent. >> >> Thanks >> Jo >> >> >> >>> >>> Thanks. >>> >>> On Wed, Dec 14, 2016 at 8:05 AM, Joseph Fonseka <[email protected]> wrote: >>> >>>> Hi >>>> >>>> +1, few clarifications bellow. >>>> >>>> 1. I guess the default mode will be OVERWRITE. >>>> 2. Why did we use comments to propagate Zones to the client side >>>> instead of Divs. >>>> >>>> Thanks >>>> Jo >>>> >>>> >>>> >>>> On Tue, Dec 13, 2016 at 10:37 PM, SajithAR Ariyarathna < >>>> [email protected]> wrote: >>>> >>>>> Hi All, >>>>> >>>>> To do $subject, we are hoping to give a UUF client JS library. With >>>>> the client-side library, webapp developers will be able to render >>>>> fragments >>>>> and push to zones similar to the server-side. >>>>> >>>>> Functions in the library: >>>>> >>>>> UUF.renderFragment(fragmentFullyQualifedName, templateFillingObject, >>>>> zoneName, mode) >>>>> >>>>> Using this function webapp developers can render a fragment in the >>>>> client-side and push the content to a given zone. >>>>> >>>>> Here, >>>>> >>>>> *fragmentFullyQualifedName* - Fully qualified name >>>>> (<component-name>.<fragment-name>) of the fragment that you want to >>>>> render. e.g. "org.wso2.carbon.apimgt.store.api-grid" >>>>> *templateFillingObject* - JSON object which will be used to fill the >>>>> fragment's template. e.g. {name: "My API", version: "1.0.0"} >>>>> >>>>> *zoneName* - Name of the zone that you want to push the rendered >>>>> HTML. e.g. "grid" >>>>> >>>>> *mode* - Dictates how the pushing content orders with the existing >>>>> content in the zone. Mode can be "PREPEND" (put the pushing content before >>>>> the existing content), "APPEND" (put the pushing content after the >>>>> existing >>>>> content) or "OVERWRITE" (replace the existing content with the pushing >>>>> content) >>>>> >>>>> >>>>> UUF.renderTemplate(hbsTemplate, templateFillingObject, zoneName, >>>>> mode) >>>>> >>>>> Using this function webapp devs can render a given Handlebars template >>>>> and push it to a desired zone. >>>>> >>>>> Here, >>>>> >>>>> *hbsTemplate* - Handlebars template string >>>>> >>>>> >>>>> Bringing zones to the client-side. >>>>> >>>>> When rendering a zone in the server-side, we can mark the start and >>>>> end of a zone's content with HTML comments. >>>>> >>>>> e.g. >>>>> >>>>> <!-- [UUF-ZONE]{"name": "grid", "position": "start"} --> >>>>> <p>content of zone grid goes here</p> >>>>> <div>here is a div</div> >>>>> <p>some more stuff</p> >>>>> <!-- [UUF-ZONE]{"name": "grid", "position": "end"} --> >>>>> >>>>> HTML comments can be identified by filtering nodes in the DOM. And >>>>> further filtering the comments that starts with [UUF-ZONE], we can >>>>> identify UUF zone marking comments. Jerad did a POC for this. In that we >>>>> were able to successfully identify zones and push content for all modes. >>>>> >>>>> >>>>> We are hoping to expose this library through the "uuf-client" fragment >>>>> in the common "foundation" component [1]. >>>>> >>>>> [1] https://github.com/wso2/carbon-uuf-common/tree/master/compo >>>>> nents/org.wso2.carbon.uuf.common.foundation >>>>> >>>>> WDYT? >>>>> >>>>> Thanks. >>>>> -- >>>>> Sajith Janaprasad Ariyarathna >>>>> Software Engineer; WSO2, Inc.; http://wso2.com/ >>>>> <https://wso2.com/signature> >>>>> >>>>> _______________________________________________ >>>>> Architecture mailing list >>>>> [email protected] >>>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>>> >>>>> >>>> >>>> >>>> -- >>>> >>>> -- >>>> *Joseph Fonseka* >>>> WSO2 Inc.; http://wso2.com >>>> lean.enterprise.middleware >>>> >>>> mobile: +94 772 512 430 >>>> skype: jpfonseka >>>> >>>> * <http://lk.linkedin.com/in/rumeshbandara>* >>>> >>>> >>>> _______________________________________________ >>>> Architecture mailing list >>>> [email protected] >>>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>>> >>>> >>> >>> >>> -- >>> Sajith Janaprasad Ariyarathna >>> Software Engineer; WSO2, Inc.; http://wso2.com/ >>> <https://wso2.com/signature> >>> >>> _______________________________________________ >>> Architecture mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >>> >> >> >> -- >> >> -- >> *Joseph Fonseka* >> WSO2 Inc.; http://wso2.com >> lean.enterprise.middleware >> >> mobile: +94 772 512 430 >> skype: jpfonseka >> >> * <http://lk.linkedin.com/in/rumeshbandara>* >> >> >> _______________________________________________ >> Architecture mailing list >> [email protected] >> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >> >> > > _______________________________________________ > Architecture mailing list > [email protected] > https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture > > -- Sajith Janaprasad Ariyarathna Software Engineer; WSO2, Inc.; http://wso2.com/ <https://wso2.com/signature>
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
