Hi Isura, On Mon, Jan 23, 2017 at 8:21 AM, Isura Karunaratne <[email protected]> wrote:
> Hi Danushka/Kasun, > > > > On Mon, Jan 23, 2017 at 7:00 AM, Kasun Bandara <[email protected]> > wrote: > >> Hi Lahiru, >> >> Is there any specific reason to populate the email configurations under >> 'config' directory ? . IMO these email template configurations must reside >> under 'Identity' directory structure. >> > > Email templates are not identity specific data. IMO email configurations > should be in the conf directory, but not in Identity directory. > Why we have email templates under identity directory in 5.3.0 is because we made a decision to contain all identity server features under one root directory, hence /identity. Not based on whether they are really a identity related feature or not. Same applies to event-mgt.properties file. Otherwise there can be naming conflicts coming from other repos. I also think all identity server features must go under one directory. Regards, Johann. > Thanks > Isura. > >> >> Thanks, >> Kasun. >> >> Kasun Gayan Bandara >> PhD Research Student >> Machine Learning Group >> >> Faculty of Information Technology, Clayton >> Monash University >> 25 Exhibition Walk, Clayton Campus >> Wellington Road >> Clayton VIC 3800 >> Australia. >> >> E: [email protected] >> M (+61) 43 491 6476 >> >> <https://www.linkedin.com/in/bandarakasun> >> >> >> >> On Sun, Jan 22, 2017 at 10:10 PM, Lahiru Manohara <[email protected]> >> wrote: >> >>> Hi, >>> >>> We are implementing email management component for IS 6.0.0. The >>> following properties will be included in the email template. >>> >>> configuration: >>> - >>> subject: >>> body: >>> footer: >>> type: >>> display: >>> locale: >>> emailContentType: >>> >>> The following directory structure will be used to keep the template >>> based on the locale. >>> >>> config/ >>> └── email/ >>> ├── en_US >>> │ └── email-admin-config.yaml >>> └── en_GB >>> └── email-admin-config.yaml >>> >>> Appreciate your suggestions on above design. >>> >>> Best Regards, >>> -- >>> *Lahiru Manohara* >>> *Software Engineer* >>> Mobile: +94716561576 >>> WSO2 Inc. | http://wso2.com >>> lean.enterprise.middleware >>> >>> _______________________________________________ >>> Architecture mailing list >>> [email protected] >>> https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture >>> >>> >> > -- Thanks & Regards, *Johann Dilantha Nallathamby* Technical Lead & Product Lead of WSO2 Identity Server Governance Technologies Team WSO2, Inc. lean.enterprise.middleware Mobile - *+94777776950* Blog - *http://nallaa.wordpress.com <http://nallaa.wordpress.com>*
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
