On Thu, Mar 9, 2017 at 12:17 PM, Ashen Weerathunga <[email protected]> wrote:
> > > On Thu, Mar 9, 2017 at 11:06 AM, Harsha Thirimanna <[email protected]> > wrote: > >> >> On Thu, Mar 9, 2017 at 10:49 AM, Ashen Weerathunga <[email protected]> >> wrote: >> >>> Hi all, >>> >>> We are in the process of moving carbon identity mgt [1] to the global >>> configuration model [2]. In this model, we need to maintain all the server >>> configurations in one configuration file (deployment.yaml). Currently, we >>> have a number of config files in the carbon identity mgt as below (please >>> add if I have missed any). >>> >>> - claim-mapping >>> >>> <https://github.com/wso2/carbon-identity-mgt/blob/master/features/org.wso2.carbon.identity.claim.feature/resources/conf/claim-mapping.yaml> >>> - profile-mapping >>> >>> <https://github.com/wso2/carbon-identity-mgt/blob/master/features/org.wso2.carbon.identity.claim.feature/resources/conf/profile-mapping.yaml> >>> - domain-config >>> >>> <https://github.com/wso2/carbon-identity-mgt/blob/master/features/org.wso2.carbon.identity.mgt.feature/resources/conf/domain-config.yaml> >>> - store-config >>> >>> <https://github.com/wso2/carbon-identity-mgt/blob/master/features/org.wso2.carbon.identity.mgt.feature/resources/conf/store-config.yaml> >>> - challenge-questions >>> >>> <https://github.com/wso2/carbon-identity-mgt/blob/master/features/org.wso2.carbon.identity.recovery.feature/resources/conf/challenge-questions/en-US.yaml> >>> - identity-management >>> >>> <https://github.com/wso2/carbon-identity-mgt/blob/master/features/org.wso2.carbon.identity.recovery.feature/resources/conf/identity-management.yaml> >>> >>> But as for the new model what are the configs that we need to move to >>> deployment.yaml? >>> >> >> What you mean by, "what are the configs" ? >> Because anyway we have to move all into an one file, right ? That is not >> possible to keep multiple files as in new model. Please make me correct if >> I didn't get what meant. >> > > Yes. But shouldn't we need to distinguish between data and server configs? > > Basically as for the new model we need to defined default config values in > the bean classes. If we need to override the default values, we need to > copy the configuration segment to the deployment.yaml file and change the > value. The server will pick the new configs from the deployment.yaml > > As an example we have large list in challenge questions > <https://github.com/wso2/carbon-identity-mgt/blob/master/features/org.wso2.carbon.identity.recovery.feature/resources/conf/challenge-questions/en-US.yaml> > file. If we are moving this to deployement.yaml we need to add all this > data to a bean class as default values. So AFAIU even if we need to add one > more question we will have to add all these questions with the new question > to the deployment.yaml. So is this the correct approach? > > We have to understand the pattern to follow when modifying/removing/adding an item in a *list* with deployment.yaml. Copying the entire list to deployment.yaml and modify accordingly is the straight-forward approach. But that does not scale well if the number of items is quite big like in this config file [1]. May be we are overseeing something? Kernel folks, please clarify. [1] https://github.com/wso2/carbon-identity-mgt/blob/master/features/org.wso2.carbon.identity.claim.feature/resources/conf/profile-mapping.yaml Thanks, KasunG >>> [1] https://github.com/wso2/carbon-identity-mgt >>> [2] https://github.com/wso2/carbon-kernel/blob/master/docs/D >>> eveloperTools/UpdatingConfigurations.md >>> >>> Thanks, >>> Ashen >>> -- >>> *Ashen Weerathunga* >>> Software Engineer >>> WSO2 Inc.: http://wso2.com >>> lean.enterprise.middleware >>> >>> Email: [email protected] >>> Mobile: +94716042995 <94716042995> >>> LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga >>> <http://lk.linkedin.com/in/ashenweerathunga>* >>> <http://wso2.com/signature> >>> >> >> > > > -- > *Ashen Weerathunga* > Software Engineer > WSO2 Inc.: http://wso2.com > lean.enterprise.middleware > > Email: [email protected] > Mobile: +94716042995 <94716042995> > LinkedIn: *http://lk.linkedin.com/in/ashenweerathunga > <http://lk.linkedin.com/in/ashenweerathunga>* > <http://wso2.com/signature> > -- *Kasun Gajasinghe*Associate Technical Lead, WSO2 Inc. email: kasung AT spamfree wso2.com linked-in: http://lk.linkedin.com/in/gajasinghe blog: http://kasunbg.org phone: +1 650-745-4499, 77 678 0813
_______________________________________________ Architecture mailing list [email protected] https://mail.wso2.org/cgi-bin/mailman/listinfo/architecture
